From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0462C433DF for ; Tue, 21 Jul 2020 03:33:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD28020792 for ; Tue, 21 Jul 2020 03:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595302412; bh=9HI1pUn9jONTwhdZhN5qt8fCBBfsHz1Gxdf3NregWQs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tgghVWLi5w7fvftQLxNbbOG5uM4EhDRqE4tyKjwn7rbNNpoBGwZ8mh7C8lVnKbROr OZC5E4GYALVkd4+ZFfEaYO0EAm03alZ7uX821Nm7LNfg3wBWANpC87n9x5BIFEpZDH vKFnHL4Pd1XG1l/xFgTFW9qXd3EJbra7w7td2Pns= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbgGUDdc (ORCPT ); Mon, 20 Jul 2020 23:33:32 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:39676 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbgGUDdb (ORCPT ); Mon, 20 Jul 2020 23:33:31 -0400 Received: by mail-io1-f67.google.com with SMTP id z6so2391892iow.6; Mon, 20 Jul 2020 20:33:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FIsq5aS0lflR5eoGS5qg3+rJGrp+o2lfnvyRp1tDhhA=; b=ELs0jonetSEQpe74Bb1hdst8HjmiOlsJkH9XNwtyZjshzN0cZjVgkiUpMYgaB2s+pS SIzms5j9UmijKOB+b2jSYSNqM8Jwnvhx0O23tOmb0gtrEN8jqCsLrzH/k610M4OR0Rnt I9YaWFLdkUtww9L9fM7HzUBJh6QHxM9QIR7EwTKqaq5lFN2Rhf6oHP0beoASMwUVUtxZ k5WLe+QR0i8+Pu437zY6a3N3xjM2Q+VViCWw3mvoDZ4r1O/fiCFrw/iIWvT8u6onM4DZ TK0Y6xil0SOvRhZTYro/mK+Gtik3Osjel2WFmQ9Pdli/iQsA1XWLyDaw94zi/V55i1K8 Bt+g== X-Gm-Message-State: AOAM531IY9DM0PEDeiszV+Hk8D+h0QCqGVRivM0pVzU947KudPPrM8Di sDQhc9uJCt89+6xmqHo0IA== X-Google-Smtp-Source: ABdhPJxLzxwkSBFgFvKAURG7gHM0n9OP8gTt/FOr/k7nGl4P1U3thGEkKqvgI5H750H/QtxdXFHIqw== X-Received: by 2002:a05:6602:2d12:: with SMTP id c18mr25892320iow.13.1595302410706; Mon, 20 Jul 2020 20:33:30 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id g1sm9885914ilk.51.2020.07.20.20.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 20:33:29 -0700 (PDT) Received: (nullmailer pid 3502407 invoked by uid 1000); Tue, 21 Jul 2020 03:33:28 -0000 Date: Mon, 20 Jul 2020 21:33:28 -0600 From: Rob Herring To: Sumit Semwal Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Mauro Carvalho Chehab , "David S . Miller" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel Message-ID: <20200721033328.GA3492972@bogus> References: <20200716153858.526-1-sumit.semwal@linaro.org> <20200716153858.526-2-sumit.semwal@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716153858.526-2-sumit.semwal@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 16, 2020 at 09:08:57PM +0530, Sumit Semwal wrote: > The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 > and 6.18 inches size. It is found in some of the Poco F1 phones. > > Signed-off-by: Sumit Semwal > --- > .../display/panel/tianma,nt36672a.yaml | 110 ++++++++++++++++++ > 1 file changed, 110 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > new file mode 100644 > index 000000000000..3c583ca926ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > @@ -0,0 +1,110 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/tianma,nt36672a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tianma model NT36672A DSI Panel display driver > + > +maintainers: > + - Sumit Semwal > + > +description: | > + The nt36672a panel from Tianma is a FHD+ LCD display panel with a resolution > + of 1080x2246. It is a video mode DSI panel. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: tianma,nt36672a > + > + reg: > + description: DSI virtual channel of the peripheral > + > + reset-gpios: > + description: phandle of gpio for reset line - This should be 8mA, gpio > + can be configured using mux, pinctrl, pinctrl-names (active high) > + > + vddio-supply: > + description: phandle of the regulator that provides the supply voltage > + Power IC supply > + > + vddpos-supply: > + description: phandle of the positive boost supply regulator > + > + vddneg-supply: > + description: phandle of the negative boost supply regulator > + > + pinctrl-names: > + description: Pinctrl for panel active and suspend > + > + pinctrl-0: > + description: Active pinctrls > + > + pinctrl-1: > + description: Suspend pinctrls I think the pinctrl should go in the DSI controller node, not the display unless it is settings for 'reset-gpios'. > + > + ports: > + type: object > + properties: > + port@0: > + type: object > + description: DSI input port driven by master DSI > + properties: > + reg: > + const: 0 > + > + required: > + - reg For a single port, you can do just 'port' (without ports node). > + > +required: > + - compatible > + - reg > + - vddi0-supply > + - vddpos-supply > + - vddneg-supply > + - reset-gpios > + - pinctrl-names > + - pinctrl-0 > + - pinctrl-1 > + - ports > + > +unevaluatedProperties: false > + > +examples: > + - |+ > + #include > + dsi0 { dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "tianma,nt36672a"; > + reg = <0>; > + vddi0-supply = <&vreg_l14a_1p88>; > + vddpos-supply = <&lab>; > + vddneg-supply = <&ibb>; > + > + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > + > + pinctrl-names = "panel_active", "panel_suspend"; > + pinctrl-0 = <&sde_dsi_active>; > + pinctrl-1 = <&sde_dsi_suspend>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + tianma_nt36672a_in_0: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + }; > + }; > + }; > + > +... > -- > 2.27.0 >