From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings
Date: Tue, 21 Jul 2020 10:32:28 +0200 [thread overview]
Message-ID: <20200721083228.GA283099@ravnborg.org> (raw)
In-Reply-To: <20200720203506.3883129-1-linus.walleij@linaro.org>
Hi Linus.
On Mon, Jul 20, 2020 at 10:35:05PM +0200, Linus Walleij wrote:
> This adds device tree bindings for the Kinetic KTD253
> white LED backlight driver.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
See a few comments in the following.
Sam
> ---
> .../leds/backlight/kinetic,ktd253.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
> new file mode 100644
> index 000000000000..610bf9a0e270
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktd253.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Kinetic Technologies KTD253 one-wire backlight
> +
> +maintainers:
> + - Linus Walleij <linus.walleij@linaro.org>
> +
> +description: |
> + The Kinetic Technologies KTD253 is a white LED backlight that is
> + controlled by a single GPIO line. If you just turn on the backlight
> + it goes to maximum backlight then you can set the level of backlight
> + using pulses on the enable wire.
No $ref for common.yaml?
> +
> +properties:
> + compatible:
> + const: kinetic,ktd253
> +
> + gpios:
A less generic and more descriptive name would be good.
> + description: GPIO to use to enable/disable and dim the backlight.
> + maxItems: 1
> +
> + default-brightness:
> + description: Default brightness level on boot. 0 is off.
> + minimum: 0
> + maximum: 255
> +
> + max-brightness:
> + description: Maximum brightness that is allowed during runtime.
> + minimum: 0
> + maximum: 255
Both looks like candidates for common.yaml - they are used by other
bindings.
> +
> +required:
> + - compatible
> + - gpios
It would make senste that maximum-brighness was mandatory too.
addtionalProperties: false??
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + backlight {
> + compatible = "kinetic,ktd253";
> + gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
> + default-on;
default-on is not documented - and not part of common.yaml.
> + default-brightness = <160>;
> + };
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-21 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 20:35 [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings Linus Walleij
2020-07-21 8:32 ` Sam Ravnborg [this message]
2020-08-12 6:48 ` Linus Walleij
2020-08-12 7:34 ` Sam Ravnborg
2020-08-12 9:09 ` Linus Walleij
2020-07-21 11:28 ` Daniel Thompson
2020-08-12 7:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721083228.GA283099@ravnborg.org \
--to=sam@ravnborg.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).