From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6CF5C433E3 for ; Tue, 21 Jul 2020 21:11:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4D0E20720 for ; Tue, 21 Jul 2020 21:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728837AbgGUVLj (ORCPT ); Tue, 21 Jul 2020 17:11:39 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:44736 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728606AbgGUVLj (ORCPT ); Tue, 21 Jul 2020 17:11:39 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 3B5AD1C0BD8; Tue, 21 Jul 2020 23:11:36 +0200 (CEST) Date: Tue, 21 Jul 2020 23:11:35 +0200 From: Pavel Machek To: Dan Murphy Cc: jacek.anaszewski@gmail.com, robh@kernel.org, marek.behun@nic.cz, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v31 06/12] leds: lp55xx: Add multicolor framework support to lp55xx Message-ID: <20200721211135.GE5966@amd> References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-7-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PGNNI9BzQDUtgA2J" Content-Disposition: inline In-Reply-To: <20200716182007.18389-7-dmurphy@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --PGNNI9BzQDUtgA2J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Add multicolor framework support for the lp55xx family. >=20 > Acked-by: Pavel Machek > Acked-by: Jacek Anaszewski > Signed-off-by: Dan Murphy Applied 4,5,6 and 8,9. > config LEDS_LP55XX_COMMON > tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501" > - depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501 > + depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR > + depends on OF > select FW_LOADER > select FW_LOADER_USER_HELPER But I have to ask: what does this do to userland interface once LEDS_CLASS_MULTICOLOR is enabled? Will users see some changes? Will they see some changes after dts parts are applied? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --PGNNI9BzQDUtgA2J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl8XWgcACgkQMOfwapXb+vJs8gCgjiyUjz1Qm40NgHKrj1ROiK6w piAAnibro4jCdEmW1PAfv4OLVl3T65wz =Hh5F -----END PGP SIGNATURE----- --PGNNI9BzQDUtgA2J--