From: Al Cooper <alcooperx@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Al Cooper <alcooperx@gmail.com>,
devicetree@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Sasi Kumar <sasi.kumar@broadcom.com>
Subject: [PATCH v3 5/7] usb: bdc: driver runs out of buffer descriptors on large ADB transfers
Date: Wed, 22 Jul 2020 13:07:44 -0400 [thread overview]
Message-ID: <20200722170746.5222-6-alcooperx@gmail.com> (raw)
In-Reply-To: <20200722170746.5222-1-alcooperx@gmail.com>
Version v1.0.40 of the Android host ADB software increased maximum
transfer sizes from 256K to 1M. Since the STB ADB gadget driver
requests only 16K at a time, the BDC driver ran out of buffer
descriptors (BDs) if the queuing happens faster than the incoming
16K transfers. This issue is fixed by doubling the number of BDs
that can be queued so that the entire 1M request can be queued
without running out of buffers.
Signed-off-by: Al Cooper <alcooperx@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/usb/gadget/udc/bdc/bdc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc.h b/drivers/usb/gadget/udc/bdc/bdc.h
index 6e1e881dc51e..ac75e25c3b6a 100644
--- a/drivers/usb/gadget/udc/bdc/bdc.h
+++ b/drivers/usb/gadget/udc/bdc/bdc.h
@@ -44,7 +44,7 @@
#define NUM_SR_ENTRIES 64
/* Num of bds per table */
-#define NUM_BDS_PER_TABLE 32
+#define NUM_BDS_PER_TABLE 64
/* Num of tables in bd list for control,bulk and Int ep */
#define NUM_TABLES 2
--
2.17.1
next prev parent reply other threads:[~2020-07-22 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 17:07 [PATCH v3 0/7] usb: bdc: Updates and fixes to the USB BDC driver Al Cooper
2020-07-22 17:07 ` [PATCH v3 1/7] dt-bindings: usb: bdc: Update compatible strings Al Cooper
2020-07-23 17:32 ` Rob Herring
2020-07-22 17:07 ` [PATCH v3 2/7] usb: bdc: Add compatible string for new style USB DT nodes Al Cooper
2020-07-22 17:07 ` [PATCH v3 3/7] bdc: Fix bug causing crash after multiple disconnects Al Cooper
2020-07-22 17:07 ` [PATCH v3 4/7] usb: bdc: Adb shows offline after resuming from S2 Al Cooper
2020-07-22 17:07 ` Al Cooper [this message]
2020-07-22 17:07 ` [PATCH v3 6/7] usb: bdc: Halt controller on suspend Al Cooper
2020-07-22 17:07 ` [PATCH v3 7/7] usb: bdc: Use devm_clk_get_optional() Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722170746.5222-6-alcooperx@gmail.com \
--to=alcooperx@gmail.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sasi.kumar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).