From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FB3C433E4 for ; Thu, 23 Jul 2020 10:42:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FC3F2086A for ; Thu, 23 Jul 2020 10:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595500920; bh=gJWA9QXauNyAZw+WmtrtvY1UtXytOLKm4um7aDhSYsU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Cwg/BqRh1abqwLOkMXhwcEXjesS2o8LzpM185sXaer1WGD2OiqbyR1uSkyO3XbwN6 DgGZeSBgPyIqYKNVC2m3CiyJ8VPr05b0dlRtM/sdVAo276ZM+faixgQ+IADnTYL/xH X3vop/grbOi1t5DBTxc/RHNO1VTDpqQe19r+REOc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728287AbgGWKl4 (ORCPT ); Thu, 23 Jul 2020 06:41:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:39944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728222AbgGWKl4 (ORCPT ); Thu, 23 Jul 2020 06:41:56 -0400 Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ECE3520737; Thu, 23 Jul 2020 10:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595500915; bh=gJWA9QXauNyAZw+WmtrtvY1UtXytOLKm4um7aDhSYsU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x3jt3fdUDgL+XmznfiwVnxiC4s/rRRpzGanzbRt4pFxjdSHJXn31dl0XGsZYWLXzX xhEmPujcs+W7mS0wYOazMC4tHxWBiQfmnV1EVcnnW2vNCBy0LLPruLxD3qbuMZBHiI udT2ehqf/iMPD5fDTRz/DlJ4BQRqwS2ih4poHKOo= Date: Thu, 23 Jul 2020 16:11:51 +0530 From: Vinod Koul To: Laurent Pinchart , Sam Ravnborg Cc: Daniel Vetter , David Airlie , Rob Clark , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Emil Velikov , Srinivas Kandagatla , John Stultz Subject: Re: [PATCH v5 3/4] drm/bridge: Introduce LT9611 DSI to HDMI bridge Message-ID: <20200723104151.GY12965@vkoul-mobl> References: <20200708103559.132300-1-vkoul@kernel.org> <20200708103559.132300-4-vkoul@kernel.org> <20200719171806.GA55541@ravnborg.org> <20200722131430.GJ5833@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200722131430.GJ5833@pendragon.ideasonboard.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sam, Laurent, On 22-07-20, 16:14, Laurent Pinchart wrote: > > > +static int lt9611_bridge_attach(struct drm_bridge *bridge, > > > + enum drm_bridge_attach_flags flags) > > > +{ > > > + struct lt9611 *lt9611 = bridge_to_lt9611(bridge); > > > + int ret; > > > + > > > + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) { > > > + dev_err(lt9611->dev, "Fix bridge driver to make connector optional!"); > > > + return -EINVAL; > > > + } > > > > This should say that the display driver should be fixed. > > If a display driver expects this bridge to create the connector > > it would not work. > > Actually, for new bridge drivers, connector creation should be optional > from the start. We don't want a failure in that case, the feature should > be implemented. Yes this is causing issues for me now !. The patch 4/4 adds support in msm/dsi but causes regression on qualcomm laptops with ti-sn65dsi86 eDP bridge. I tried to fix that up with changes like Laurent has done for adv7511, but it hasnt worked yet for me (remote debug of this is bit painful) So I am going to drop patch 4 from this series and add support for both DRM_BRIDGE_ATTACH_NO_CONNECTOR set and cleared (like we have in adv7511) so that it can work in both cases, while I fix all bridge uses of msm/dsi and then we can drop these. Does that sound okay to you folks? -- ~Vinod