From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEE8C433E1 for ; Thu, 23 Jul 2020 12:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A91302080D for ; Thu, 23 Jul 2020 12:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595506239; bh=eSF1O/MPFAgzk9HDIMFIg1UmW6izaaYh4M3av+WBB5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=iQ8pTsboQ5BQkitcnQtl6LQSi6CrJV67qJVbT8QQyq8OzZDLEzqenrC4FmnfiNHDk MXEn07oyY0vsnHz3RwWQMqzGhWXE6gqO1s0/m9zNpz9whFxQvplvIrf52GKcDK4pGP Q5RtSkS0hFu/zKOa8uvgTP3souMXBuPKef/Pb+yI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbgGWMKj (ORCPT ); Thu, 23 Jul 2020 08:10:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:34858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726714AbgGWMKj (ORCPT ); Thu, 23 Jul 2020 08:10:39 -0400 Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 820F420709; Thu, 23 Jul 2020 12:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595506238; bh=eSF1O/MPFAgzk9HDIMFIg1UmW6izaaYh4M3av+WBB5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eUBlib0URNNKizHNTmWwA3Xtv4n94Sey+jkjk4xuo7gmwo8/sFTNwigwF9osh7DiH Rq6Kk68saahw0pWsizNtXauDaTtpxrFnolD2FQirpFRvc9saBEUznu5BvsmZADMgPN Ar07tvoXy492obYkCnxgJ4tSBrHgUi8Oh5/AJaIA= Date: Thu, 23 Jul 2020 17:40:34 +0530 From: Vinod Koul To: Sam Ravnborg Cc: Laurent Pinchart , Daniel Vetter , David Airlie , Rob Clark , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Emil Velikov , Srinivas Kandagatla , John Stultz Subject: Re: [PATCH v5 3/4] drm/bridge: Introduce LT9611 DSI to HDMI bridge Message-ID: <20200723121034.GA12965@vkoul-mobl> References: <20200708103559.132300-1-vkoul@kernel.org> <20200708103559.132300-4-vkoul@kernel.org> <20200719171806.GA55541@ravnborg.org> <20200722131430.GJ5833@pendragon.ideasonboard.com> <20200723104151.GY12965@vkoul-mobl> <20200723113912.GA535520@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200723113912.GA535520@ravnborg.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23-07-20, 13:39, Sam Ravnborg wrote: > On Thu, Jul 23, 2020 at 04:11:51PM +0530, Vinod Koul wrote: > > Hi Sam, Laurent, > > > > On 22-07-20, 16:14, Laurent Pinchart wrote: > > > > > +static int lt9611_bridge_attach(struct drm_bridge *bridge, > > > > > + enum drm_bridge_attach_flags flags) > > > > > +{ > > > > > + struct lt9611 *lt9611 = bridge_to_lt9611(bridge); > > > > > + int ret; > > > > > + > > > > > + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) { > > > > > + dev_err(lt9611->dev, "Fix bridge driver to make connector optional!"); > > > > > + return -EINVAL; > > > > > + } > > > > > > > > This should say that the display driver should be fixed. > > > > If a display driver expects this bridge to create the connector > > > > it would not work. > > > > > > Actually, for new bridge drivers, connector creation should be optional > > > from the start. We don't want a failure in that case, the feature should > > > be implemented. > > > > Yes this is causing issues for me now !. The patch 4/4 adds support in > > msm/dsi but causes regression on qualcomm laptops with ti-sn65dsi86 eDP > > bridge. I tried to fix that up with changes like Laurent has done for > > adv7511, but it hasnt worked yet for me (remote debug of this is bit > > painful) > > > > So I am going to drop patch 4 from this series and add support for both > > DRM_BRIDGE_ATTACH_NO_CONNECTOR set and cleared (like we have in adv7511) > > so that it can work in both cases, while I fix all bridge uses of > > msm/dsi and then we can drop these. Does that sound okay to you folks? > Yes, sounds like a good plan. > Only when all display drivers are migrated over can we drop all the > workarounds in the bridge drivers. > I had hoped all users of this bridge was converted - alas that was not > the case. Thanks, I will send updated patchset fixing the nits and supporting both the cases and will drop msm/dsi patch for now -- ~Vinod