From: Rob Herring <robh@kernel.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, devicetree@vger.kernel.org,
linux-imx@nxp.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/4] doc: dt-binding: ci-hdrc-usb2: add property for imx picophy
Date: Thu, 23 Jul 2020 11:35:25 -0600 [thread overview]
Message-ID: <20200723173525.GA576802@bogus> (raw)
In-Reply-To: <20200717042226.18495-1-peter.chen@nxp.com>
On Fri, Jul 17, 2020 at 12:22:23PM +0800, Peter Chen wrote:
> Add two parameters which are used to tune USB signal for imx picophy,
> picophy is used at imx7d, imx8mm, and imx8mn.
>
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> No changes for v2.
>
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> index 51376cbe5f3d..e9858dafb08f 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> @@ -100,6 +100,13 @@ i.mx specific properties
> It's recommended to specify the over current polarity.
> - power-active-high: power signal polarity is active high
> - external-vbus-divider: enables off-chip resistor divider for Vbus
> +- picophy,pre-emp-curr-control: HS Transmitter Pre-Emphasis Current
Form is <vendor>,<prop-name> and picophy is not a vendor.
> + Control. This signal controls the amount of current sourced to the
> + USB_OTG*_DP and USB_OTG*_DN pins after a J-to-K or K-to-J transition.
> + Details can refer to TXPREEMPAMPTUNE0 bits of USBNC_n_PHY_CFG1.
What's the range of values? What's the default if not specified?
> +- picophy,dc-vol-level-adjust: HS DC Voltage Level Adjustment.
> + Adjust the high-speed transmitter DC level voltage, details can refer
> + to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1.
Same comments here.
>
> Example:
>
> --
> 2.17.1
>
prev parent reply other threads:[~2020-07-23 17:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 4:22 [PATCH v2 1/4] doc: dt-binding: ci-hdrc-usb2: add property for imx picophy Peter Chen
2020-07-17 4:22 ` [PATCH v2 2/4] usb: chipidea: imx: add two picophy parameters tuning implementation Peter Chen
2020-07-17 4:22 ` [PATCH v2 3/4] arm64: dts: imx8mm-evk: add two parameters for picophy tuning Peter Chen
2020-07-17 4:22 ` [PATCH v2 4/4] arm64: dts: imx8mn-evk: " Peter Chen
2020-07-23 17:35 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723173525.GA576802@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).