From: Rob Herring <robh@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Suniel Mahesh <sunil@amarulasolutions.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-amarula <linux-amarula@amarulasolutions.com>
Subject: Re: [PATCH v2 1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding
Date: Thu, 23 Jul 2020 14:22:07 -0600 [thread overview]
Message-ID: <20200723202207.GA794123@bogus> (raw)
In-Reply-To: <20200722190949.215656-1-jagan@amarulasolutions.com>
On Thu, Jul 23, 2020 at 12:39:44AM +0530, Jagan Teki wrote:
> ROCKPi 4 has 3 variants of hardware platforms called
> ROCKPi 4A, 4B, and 4C.
>
> - ROCKPi 4A has no Wif/BT.
> - ROCKPi 4B has AP6256 Wifi/BT, PoE.
> - ROCKPi 4C has AP6256 Wifi/BT, PoE, miniDP, USB Host enabled
> GPIO pin change compared to 4B, 4C
>
> So, update the existing ROCKPi 4 with ROCKPi 4A binding.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - new patch
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 41f919de1ad4..36057c9e4b83 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -442,9 +442,10 @@ properties:
> - const: radxa,rock
> - const: rockchip,rk3188
>
> - - description: Radxa ROCK Pi 4
> + - description: Radxa ROCK Pi 4A
> items:
> - const: radxa,rockpi4
> + - const: radxa,rockpi4a
> - const: rockchip,rk3399
That's not what I suggested. And this is just wrong as the order is most
specific to least specific.
This is what I suggest:
items:
- enum:
- radxa,rockpi4 # ROCK Pi 4A
- radxa,rockpi4b
- radxa,rockpi4c
- const: rockchip,rk3399
>
> - description: Radxa ROCK Pi N8
> --
> 2.25.1
>
prev parent reply other threads:[~2020-07-23 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 19:09 [PATCH v2 1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding Jagan Teki
2020-07-22 19:09 ` [PATCH v2 2/6] arm64: dts: rockchip: Mark rock-pi-4 as rock-pi-4a dts Jagan Teki
2020-07-22 19:09 ` [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding Jagan Teki
2020-07-22 23:13 ` Heiko Stuebner
2020-07-23 6:34 ` Jagan Teki
2020-07-23 8:27 ` Heiko Stübner
2020-07-22 19:09 ` [PATCH v2 4/6] arm64: dts: rockchip: Add Radxa ROCK Pi 4B support Jagan Teki
2020-07-22 19:09 ` [PATCH v2 5/6] dt-bindings: arm: rockchip: Add ROCKPi 4C binding Jagan Teki
2020-07-22 19:09 ` [PATCH v2 6/6] arm64: dts: rockchip: Add Radxa ROCK Pi 4C support Jagan Teki
2020-07-23 20:22 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723202207.GA794123@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael@amarulasolutions.com \
--cc=sunil@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).