From: Sam Ravnborg <sam@ravnborg.org>
To: Marek Vasut <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/bridge: tc358762: Add basic driver for Toshiba TC358762 DSI-to-DPI bridge
Date: Sun, 26 Jul 2020 22:41:45 +0200 [thread overview]
Message-ID: <20200726204145.GA3750553@ravnborg.org> (raw)
In-Reply-To: <a8d6b9ad-a9c4-925b-e9f8-00c803b30e9a@denx.de>
Hi Marek.
On Sun, Jul 26, 2020 at 12:17:46PM +0200, Marek Vasut wrote:
> On 7/26/20 9:15 AM, Sam Ravnborg wrote:
> > Hi Marek.
>
> Hi,
>
> > On Sat, Jul 25, 2020 at 11:14:57PM +0200, Marek Vasut wrote:
> >> Add very basic driver for Toshiba TC358762 DSI-to-DPI bridge, derived
> >> from tc358764 driver and panel-raspberrypi-touchscreen. This driver is
> >> meant to replace the panel-raspberrypi-touchscreen too, as the bridge
> >> connection can be described in DT too.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> To: dri-devel@lists.freedesktop.org
> >> Cc: Eric Anholt <eric@anholt.net>
> >> Cc: Rob Herring <robh+dt@kernel.org>
> >> Cc: Sam Ravnborg <sam@ravnborg.org>
> >> Cc: devicetree@vger.kernel.org
> >> ---
> >
> > Two general comments.
> > - This driver should use the bridge panel - this will simplify the
> > driver in many places. We already have several good examples in-tree
> > that does this.
>
> Can you list such an example ?
Take a look at tc358764.c in following patch-set:
https://lore.kernel.org/dri-devel/20200726203324.3722593-1-sam@ravnborg.org/
Your current driver will be even smaller after implmenting these
changes.
Sam
next prev parent reply other threads:[~2020-07-26 20:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 21:14 [PATCH 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge Marek Vasut
2020-07-25 21:14 ` [PATCH 2/2] drm/bridge: tc358762: Add basic driver " Marek Vasut
2020-07-26 7:15 ` Sam Ravnborg
2020-07-26 10:17 ` Marek Vasut
2020-07-26 20:41 ` Sam Ravnborg [this message]
2020-07-26 7:06 ` [PATCH 1/2] dt-bindings: Add DT bindings " Sam Ravnborg
2020-07-26 10:13 ` Marek Vasut
2020-07-27 18:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726204145.GA3750553@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).