Re: [PATCH 2/2] power: supply: bq25790: Introduce the BQ25790 charger driver

Dan Carpenter
2020-08-05T15:46:02Z

[-- Attachment #1: Type: text/plain, Size: 2498 bytes --]

Hi Dan,

url: https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-power-Add-the-bq25790-dt-bindings/20200730-225910
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: x86_64-randconfig-m001-20200731 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/power/supply/bq25790_charger.c:170 bq25790_usb_work() warn: ignoring unreachable code.
drivers/power/supply/bq25790_charger.c:624 bq25790_get_property() warn: should this be a bitwise op?
drivers/power/supply/bq25790_charger.c:904 bq25790_hw_init() error: buffer overflow 'bq25790_watchdog_time' 8 <= 8

# https://github.com/0day-ci/linux/commit/e5cf0f04730928b191aff54ab64bdd2167b2ecd4
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout e5cf0f04730928b191aff54ab64bdd2167b2ecd4
vim +170 drivers/power/supply/bq25790_charger.c

e5cf0f04730928 Dan Murphy 2020-07-30 154 static void bq25790_usb_work(struct work_struct *data)
e5cf0f04730928 Dan Murphy 2020-07-30 155 {
e5cf0f04730928 Dan Murphy 2020-07-30 156 struct bq25790_device *bq =
e5cf0f04730928 Dan Murphy 2020-07-30 157 container_of(data, struct bq25790_device, usb_work);
e5cf0f04730928 Dan Murphy 2020-07-30 158
e5cf0f04730928 Dan Murphy 2020-07-30 159 switch (bq->usb_event) {
e5cf0f04730928 Dan Murphy 2020-07-30 160 case USB_EVENT_ID:
e5cf0f04730928 Dan Murphy 2020-07-30 161 break;
e5cf0f04730928 Dan Murphy 2020-07-30 162
e5cf0f04730928 Dan Murphy 2020-07-30 163 case USB_EVENT_NONE:
e5cf0f04730928 Dan Murphy 2020-07-30 164 power_supply_changed(bq->charger);
e5cf0f04730928 Dan Murphy 2020-07-30 165 break;
e5cf0f04730928 Dan Murphy 2020-07-30 166 }
e5cf0f04730928 Dan Murphy 2020-07-30 167
e5cf0f04730928 Dan Murphy 2020-07-30 168 return;
^^^^^^
e5cf0f04730928 Dan Murphy 2020-07-30 169
e5cf0f04730928 Dan Murphy 2020-07-30 @170 dev_err(bq->dev, "Error switching to charger mode.\n");
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unreachable.

e5cf0f04730928 Dan Murphy 2020-07-30 171 }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36721 bytes --]