Re: [PATCH 1/2] dt-bindings: power: Add the bq25790 dt bindings

Rob Herring
2020-07-31T22:40:35Z

On Thu, Jul 30, 2020 at 09:58:33AM -0500, Dan Murphy wrote:
> Add the bindings for the bq25790.
>
> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> .../bindings/power/supply/bq25790.yaml | 87 +++++++++++++++++++
> 1 file changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/bq25790.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq25790.yaml b/Documentation/devicetree/bindings/power/supply/bq25790.yaml
> new file mode 100644
> index 000000000000..97dd539c1625
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq25790.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2020 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/bq25790.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: TI BQ25790 Switch Mode Buck-Boost Charger
> +
> +maintainers:
> + - Dan Murphy <dmurphy@ti.com>
> +
> +description: |
> + BQ25790 is a highly integrated switch-mode buck-boost charger for 1-4 cell
> + Li-ion batteries and Li-polymer batteries. The device charges a battery from a
> + wide range of input sources including legacy USB adapters to high voltage USB
> + PD adapters and traditional barrel adapters.
> +
> +allOf:
> + - $ref: power-supply.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - ti,bq25790
> + - ti,bq25792
> +
> + reg:
> + maxItems: 1
> +
> + ti,watchdog-timer:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Watchdog timer in milli seconds. 0 (default) disables the watchdog.

Add a standard unit suffix and you can drop the type. And maybe
s/timer/timeout/ would be a bit clearer.

Also:

default: 0

> + minimum: 0
> + maximum: 160000
> + enum: [ 0, 500, 1000, 2000, 20000, 40000, 80000, 160000]
> +
> + input-voltage-limit-microvolt:
> + description: |
> + Minimum input voltage limit in micro volts with a 100000 micro volt step.
> + minimum: 3600000
> + maximum: 22000000
> +
> + input-current-limit-microamp:
> + description: |
> + Maximum input current limit in micro amps with a 100000 micro amp step.
> + minimum: 100000
> + maximum: 3300000
> +
> + monitored-battery:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: phandle to the battery node being monitored
> +
> +required:
> + - compatible
> + - reg
> + - monitored-battery

Add:

unevaluatedProperties: false

> +
> +examples:
> + - |
> + bat: battery {
> + compatible = "simple-battery";
> + constant-charge-current-max-microamp = <2000000>;
> + constant-charge-voltage-max-microvolt = <4200000>;
> + precharge-current-microamp = <160000>;
> + charge-term-current-microamp = <160000>;
> + };
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bq25790: charger@6b {
> + compatible = "ti,bq25790";
> + reg = <0x6b>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <16 IRQ_TYPE_EDGE_FALLING>;

Not documented.

> + ti,watchdog-timer = <2000>;
> + input-current-limit = <3000000>;
> + input-voltage-limit = <4500000>;

Doesn't match the schema.

> + monitored-battery = <&bat>;
> + };
> + };
> +
> +...
> --
> 2.28.0
>