From: Rob Herring <robh@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, pisa@cmp.felk.cvut.cz
Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org,
mkl@pengutronix.de, socketcan@hartkopp.net, wg@grandegger.com,
davem@davemloft.net, mark.rutland@arm.com, c.emde@osadl.org,
armbru@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, martin.jerabek01@gmail.com,
ondrej.ille@gmail.com, jnovak@fel.cvut.cz, jara.beran@gmail.com,
porazil@pikron.com
Subject: Re: [PATCH v4 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core.
Date: Thu, 6 Aug 2020 08:47:13 -0600 [thread overview]
Message-ID: <20200806144713.GA829771@bogus> (raw)
In-Reply-To: <20200804092021.yd3wisz3g2ed6ioe@duo.ucw.cz>
On Tue, Aug 04, 2020 at 11:20:21AM +0200, Pavel Machek wrote:
> On Tue 2020-08-04 11:18:17, Pavel Machek wrote:
> > Hi!
> >
> > > The commit text again to make checkpatch happy.
> >
> > ?
> >
> >
> > > + oneOf:
> > > + - items:
> > > + - const: ctu,ctucanfd
> > > + - const: ctu,canfd-2
> > > + - const: ctu,ctucanfd
> >
> > For consistency, can we have ctu,canfd-1, ctu,canfd-2?
>
> Make it ctu,ctucanfd-1, ctu,ctucanfd-2... to make it consistent with
> the file names.
If you are going to do version numbers, please define where they come
from. Hopefully some tag of the h/w IP version...
Better yet, put version numbers in the h/w registers itself and you
don't need different compatibles.
Rob
next prev parent reply other threads:[~2020-08-06 16:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 18:34 [PATCH v4 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation pisa
2020-08-03 18:34 ` [PATCH v4 1/6] dt-bindings: vendor-prefix: add prefix for the Czech Technical University in Prague pisa
2020-08-03 18:34 ` [PATCH v4 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core pisa
2020-08-04 9:18 ` Pavel Machek
2020-08-04 9:20 ` Pavel Machek
2020-08-06 14:47 ` Rob Herring [this message]
2020-08-06 15:53 ` Pavel Pisa
2020-08-06 14:43 ` Rob Herring
2020-08-03 18:34 ` [PATCH v4 3/6] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part pisa
2020-08-03 22:02 ` kernel test robot
2020-08-04 9:57 ` Pavel Machek
2020-08-03 18:34 ` [PATCH v4 4/6] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support pisa
2020-08-03 19:32 ` Randy Dunlap
2020-08-03 22:43 ` kernel test robot
2020-08-03 18:34 ` [PATCH v4 5/6] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support pisa
2020-08-03 18:34 ` [PATCH v4 6/6] docs: ctucanfd: CTU CAN FD open-source IP core documentation pisa
2020-08-03 20:29 ` [PATCH v4 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806144713.GA829771@bogus \
--to=robh@kernel.org \
--cc=armbru@redhat.com \
--cc=c.emde@osadl.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jara.beran@gmail.com \
--cc=jnovak@fel.cvut.cz \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.jerabek01@gmail.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pavel@ucw.cz \
--cc=pisa@cmp.felk.cvut.cz \
--cc=porazil@pikron.com \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).