From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 9/9] arm64: dts: renesas: r8a774e1-hihope-rzg2h: Setup DU clocks
Date: Thu, 13 Aug 2020 15:57:32 +0300 [thread overview]
Message-ID: <20200813125732.GF6057@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200812163654.GT6057@pendragon.ideasonboard.com>
On Wed, Aug 12, 2020 at 07:36:54PM +0300, Laurent Pinchart wrote:
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Wed, Aug 12, 2020 at 03:02:17PM +0100, Lad Prabhakar wrote:
> > Setup up the required clocks for the DU to be functional.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts b/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
> > index cdbe527e9340..12f9242e263b 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
> > @@ -24,3 +24,14 @@
> > reg = <0x5 0x00000000 0x0 0x80000000>;
> > };
> > };
> > +
> > +&du {
> > + clocks = <&cpg CPG_MOD 724>,
> > + <&cpg CPG_MOD 723>,
> > + <&cpg CPG_MOD 721>,
> > + <&versaclock5 1>,
> > + <&x302_clk>,
> > + <&versaclock5 2>;
> > + clock-names = "du.0", "du.1", "du.3",
> > + "dclkin.0", "dclkin.1", "dclkin.3";
>
> I have no reason to doubt this is correct, but I also can't assess that
> as I don't have access to the schematics.
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Upgrading to
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
:-)
>
> > +};
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-08-13 12:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 14:02 [PATCH 0/9] r8a774e1 add support for DU, HDMI and LVDS Lad Prabhakar
2020-08-12 14:02 ` [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings Lad Prabhakar
2020-08-12 16:09 ` Laurent Pinchart
2020-08-13 9:05 ` Geert Uytterhoeven
2020-08-13 10:38 ` Lad, Prabhakar
2020-08-13 10:59 ` Laurent Pinchart
2020-08-13 11:08 ` Lad, Prabhakar
2020-08-13 11:11 ` Laurent Pinchart
2020-08-13 11:20 ` Lad, Prabhakar
2020-08-12 14:02 ` [PATCH 2/9] drm: rcar-du: Add support for R8A774E1 SoC Lad Prabhakar
2020-08-12 16:13 ` Laurent Pinchart
2020-08-12 14:02 ` [PATCH 3/9] arm64: dts: renesas: r8a774e1: Populate DU device node Lad Prabhakar
2020-08-12 16:16 ` Laurent Pinchart
2020-08-13 9:08 ` Geert Uytterhoeven
2020-08-12 14:02 ` [PATCH 4/9] dt-bindings: display: renesas,lvds: Document r8a774e1 bindings Lad Prabhakar
2020-08-12 16:17 ` Laurent Pinchart
2020-08-12 16:18 ` Laurent Pinchart
2020-08-13 9:09 ` Geert Uytterhoeven
2020-08-24 23:20 ` [PATCH 4/9] dt-bindings: display: renesas, lvds: " Rob Herring
2020-08-12 14:02 ` [PATCH 5/9] dt-bindings: display: renesas,dw-hdmi: Add r8a774e1 support Lad Prabhakar
2020-08-12 16:20 ` Laurent Pinchart
2020-08-13 9:10 ` Geert Uytterhoeven
2020-08-24 23:20 ` [PATCH 5/9] dt-bindings: display: renesas, dw-hdmi: " Rob Herring
2020-08-12 14:02 ` [PATCH 6/9] arm64: dts: renesas: r8a774e1: Populate HDMI encoder node Lad Prabhakar
2020-08-12 16:28 ` Laurent Pinchart
2020-08-13 9:14 ` Geert Uytterhoeven
2020-08-12 14:02 ` [PATCH 7/9] drm: rcar-du: lvds: Add support for R8A774E1 SoC Lad Prabhakar
2020-08-12 16:29 ` Laurent Pinchart
2020-08-12 14:02 ` [PATCH 8/9] arm64: dts: renesas: r8a774e1: Add LVDS device node Lad Prabhakar
2020-08-12 16:31 ` Laurent Pinchart
2020-08-13 9:17 ` Geert Uytterhoeven
2020-08-12 14:02 ` [PATCH 9/9] arm64: dts: renesas: r8a774e1-hihope-rzg2h: Setup DU clocks Lad Prabhakar
2020-08-12 16:36 ` Laurent Pinchart
2020-08-13 12:57 ` Laurent Pinchart [this message]
2020-08-13 9:19 ` Geert Uytterhoeven
2020-08-12 16:38 ` [PATCH 0/9] r8a774e1 add support for DU, HDMI and LVDS Laurent Pinchart
2020-08-12 16:43 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813125732.GF6057@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).