From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F9AC433E1 for ; Mon, 17 Aug 2020 07:03:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFA602072D for ; Mon, 17 Aug 2020 07:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597647794; bh=3bfDu2rrgsQUUDMAmYFHILNOphrIGlyzCv66V1HnZQE=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=yCeGfZgO9aYTcuQ5yIOAyJAYhuMSn7tuFMWj3pLVNwA9sjYMM8NZK1HniWtf0ydpO ILF+zCPZCmh/TsyB1kM2j9K0r/3UtHcLxtdeonkDU50I52IfP6FywBOdshf3C9DUWQ l8FGj8ULqzUBklCTfnnDp2kU6TZxE/fC8vjs2U58= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbgHQHDN (ORCPT ); Mon, 17 Aug 2020 03:03:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:41856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726361AbgHQHAb (ORCPT ); Mon, 17 Aug 2020 03:00:31 -0400 Received: from localhost.localdomain (unknown [194.230.155.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C54A20758; Mon, 17 Aug 2020 07:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597647630; bh=3bfDu2rrgsQUUDMAmYFHILNOphrIGlyzCv66V1HnZQE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=I63P1FcNXsuQY4aeMwlAuNyXbpcagMDe1fxc3eAmejIj0FDVJWDAsDhq8Hi/H9u2Y j/5F3JYtb+khaO0SLHDXajJhwLYM1nzyyhkMkLPozWgIydDLpEX72o/qoYOTIQX7IZ uw/Ka3IwtG2RQCyoLCY5KeKuJwjlA79yAf9xFnfY= From: Krzysztof Kozlowski To: MyungJoo Ham , Chanwoo Choi , Rob Herring , Krzysztof Kozlowski , Vijai Kumar K , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 06/13] extcon: ptn5150: Simplify getting vbus-gpios with flags Date: Mon, 17 Aug 2020 09:00:02 +0200 Message-Id: <20200817070009.4631-7-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817070009.4631-1-krzk@kernel.org> References: <20200817070009.4631-1-krzk@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Instead of obtaining GPIO as input and configuring it right after to output-low, just use proper GPIOD_OUT_LOW flag. Code is smaller and simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-ptn5150.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c index 12e52ddbd77e..3b99ad41b06e 100644 --- a/drivers/extcon/extcon-ptn5150.c +++ b/drivers/extcon/extcon-ptn5150.c @@ -239,16 +239,11 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c, info->dev = &i2c->dev; info->i2c = i2c; - info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN); + info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_OUT_LOW); if (IS_ERR(info->vbus_gpiod)) { dev_err(dev, "failed to get VBUS GPIO\n"); return PTR_ERR(info->vbus_gpiod); } - ret = gpiod_direction_output(info->vbus_gpiod, 0); - if (ret) { - dev_err(dev, "failed to set VBUS GPIO direction\n"); - return -EINVAL; - } mutex_init(&info->mutex); -- 2.17.1