From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01777C433E1 for ; Tue, 18 Aug 2020 08:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF3F12075E for ; Tue, 18 Aug 2020 08:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726569AbgHRI62 (ORCPT ); Tue, 18 Aug 2020 04:58:28 -0400 Received: from muru.com ([72.249.23.125]:40720 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbgHRI61 (ORCPT ); Tue, 18 Aug 2020 04:58:27 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 317F7810D; Tue, 18 Aug 2020 08:58:25 +0000 (UTC) Date: Tue, 18 Aug 2020 11:58:53 +0300 From: Tony Lindgren To: Andreas Kemnade Cc: Adam Ford , Linux-OMAP , Adam Ford-BE , =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , devicetree , Linux Kernel Mailing List , "H. Nikolaus Schaller" Subject: Re: [PATCH V2] ARM: dts: omap3: Add cpu trips and cooling map for omap34/36 families Message-ID: <20200818085853.GO2994@atomide.com> References: <20200817133931.11785-1-aford173@gmail.com> <20200817215953.59607c11@aktux> <20200817221532.5d150648@aktux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200817221532.5d150648@aktux> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Andreas Kemnade [200817 20:15]: > On Mon, 17 Aug 2020 15:02:27 -0500 > Adam Ford wrote: > > > On Mon, Aug 17, 2020 at 2:59 PM Andreas Kemnade wrote: > > > > > > On Mon, 17 Aug 2020 08:39:31 -0500 > > > Adam Ford wrote: > > > > > > > The OMAP3530, OMAP3630, and DM3730 all show thresholds of 90C and 105C > > > > depending on commercial or industrial temperature ratings. > > > > > > > > This patch expands the thermal information to include the limits of 90 > > > > and 105C for alert and critical. It sets the coolings-cells for the > > > > 34xx and 36xx CPU's which both point to omap3-cpu-thermal.dtsi. > > > > > > > > For boards who never use industrial temperatures, these can be > > > > changed on their respective device trees with something like: > > > > > > > > &cpu_alert0 { > > > > temperature = <85000>; /* millicelsius */ > > > > }; > > > > > > > > &cpu_crit { > > > > temperature = <90000>; /* millicelsius */ > > > > }; I think you should set the lower temperatures by default and have only the boards known to work with higher values configure them as needed. > > > > OMAP3_THERMAL will need to be enabled. It is off by default. > > > > > > > hmm, I think the patch for idling core when OMAP3_THERMAL is enabled > > > got stuck somewhere. It still seems not to work. Shouldn't that patch > > > be applied first? > > > > I rebased the idle stuff, and now I get errors, so I haven't pushed it > > yet. I put a note that OMAP3_THERMAL is off by default, but this > > patch would at least get the framing in there. I know at least two of > > us that use 1GHZ processors which are not supposed to run at that > > speed above 90MHz, so the idea was to tolerate the higher current for > > now, and when the idle stuff works, we'll enable the OMAP3_THERMAL by > > default. > > > yes, makes sense, so with this patch we have the choice to either > optimize for low speeds and currents (by disabling OMAP3_THERMAL and > 1GHz) or high speeds (by enabling OMAP3_THERMAL and 1 Ghz). Maybe add something like that to the patch description too? Regards, Tony