From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E71C433DF for ; Tue, 18 Aug 2020 10:37:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1F972075E for ; Tue, 18 Aug 2020 10:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597747055; bh=xcEDk+m+glN3qf3EHS7yRPVEgKV2+j6JUm4tvbC33dI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=2MRUv9ADdN4aNl1cVK/I0CoBMCQmSKKbrerSBw1Ltsg7qQETMuyZdJfu0i0+thXya 4twyqPyGCjwTsIjtvB6JucVZKSd9W7R0fwVkEl2PdtHmIjeyxw+J2UYSS46PPoORao 7AW8CLyYt5Ig9x1kDOohaW2DYMX9ml3Y+wgHOm3E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbgHRKhe (ORCPT ); Tue, 18 Aug 2020 06:37:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:47042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726862AbgHRKhb (ORCPT ); Tue, 18 Aug 2020 06:37:31 -0400 Received: from coco.lan (ip5f5ad5a3.dynamic.kabel-deutschland.de [95.90.213.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 796D9204EA; Tue, 18 Aug 2020 10:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597747050; bh=xcEDk+m+glN3qf3EHS7yRPVEgKV2+j6JUm4tvbC33dI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rrqjEXVyogXgFmEPm0UJiwXSLh0Ydlb3WnZ756K7M/o4ayb1HRItIPvnJF9Bhc9OL M80o73E0cGR95LFp6oLgJ1OovCWUk74dTPYEc33FjHWUgq3dBb6eODn7qhtM8+ycmN SFPcmIgKgUmfvsKzhij8xn6jPPxWCoiVgDoFe3Yg= Date: Tue, 18 Aug 2020 12:37:25 +0200 From: Mauro Carvalho Chehab To: Rob Herring Cc: Greg Kroah-Hartman , linuxarm@huawei.com, mauro.chehab@huawei.com, Lee Jones , Stephen Boyd , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3 43/44] dt: document HiSilicon SPMI controller and mfd/regulator properties Message-ID: <20200818123725.5b70af9b@coco.lan> In-Reply-To: <20200818111351.7e3fc780@coco.lan> References: <2f88fed96d67b05fc033356fdbb7e3227955ab34.1597647359.git.mchehab+huawei@kernel.org> <20200817201211.GA1437827@bogus> <20200818111351.7e3fc780@coco.lan> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Em Tue, 18 Aug 2020 11:13:51 +0200 Mauro Carvalho Chehab escreveu: > Em Mon, 17 Aug 2020 14:12:11 -0600 > Rob Herring escreveu: > > > > + 'irq-mask-addr': > > > + description: Address for the interrupt request mask > > > + > > > + 'irq-addr': > > > + description: Address for the interrupt request > > Those two seems more standard to me: irq-mask-addr is the address to > enable/disable IRQs, while irq-addr is where the pending IRQs are > stored. > > What would be the standard way to specify them both? After another look at the driver, both seems to be fixed address. There are even some comments that implies that: /* SOC_PMIC_IRQ_MASK_0_ADDR */ ret = of_property_read_u32(np, "irq-mask-addr", &pmic->irq_mask_addr); /* SOC_PMIC_IRQ0_ADDR */ ret = of_property_read_u32(np, "irq-addr", &pmic->irq_addr); So, I'll just drop the entire set of irq-* properties. The PMIC part should be just this: #include ... pmic: pmic@0 { compatible = "hisilicon,hi6421v600-spmi"; reg = <0 SPMI_USID>; #interrupt-cells = <2>; interrupt-controller; gpios = <&gpio28 0 0>; ... }; Thanks, Mauro