From: Rob Herring <robh@kernel.org>
To: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc: linux-pm@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, sre@kernel.org,
devicetree@vger.kernel.org, dmurphy@ti.com
Subject: Re: [PATCH v1 1/2] dt-bindings: power: Add the bq256xx dt bindings
Date: Tue, 18 Aug 2020 10:36:53 -0600 [thread overview]
Message-ID: <20200818163653.GA3586878@bogus> (raw)
In-Reply-To: <20200817191723.22416-2-r-rivera-matos@ti.com>
On Mon, 17 Aug 2020 14:17:22 -0500, Ricardo Rivera-Matos wrote:
> Add the bindings for the bq256xx series of battery charging ICs.
>
> Datasheets:
> - https://www.ti.com/lit/ds/symlink/bq25600.pdf
> - https://www.ti.com/lit/ds/symlink/bq25601.pdf
> - https://www.ti.com/lit/ds/symlink/bq25600d.pdf
> - https://www.ti.com/lit/ds/symlink/bq25601d.pdf
> - https://www.ti.com/lit/ds/symlink/bq25611d.pdf
> - https://www.ti.com/lit/ds/symlink/bq25618.pdf
> - https://www.ti.com/lit/ds/symlink/bq25619.pdf
>
> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
> ---
> .../bindings/power/supply/bq256xx.yaml | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/bq256xx.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/bq256xx.example.dt.yaml: battery: 'termination-current-microamp' does not match any of the regexes: '^ocv-capacity-table-[0-9]+$', 'pinctrl-[0-9]+'
See https://patchwork.ozlabs.org/patch/1346479
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-08-18 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 19:17 [PATCH v1 0/2] Introduce the BQ256XX family of chargers Ricardo Rivera-Matos
2020-08-17 19:17 ` [PATCH v1 1/2] dt-bindings: power: Add the bq256xx dt bindings Ricardo Rivera-Matos
2020-08-18 16:36 ` Rob Herring [this message]
2020-08-18 16:43 ` Rob Herring
2020-08-18 16:56 ` Dan Murphy
2020-08-27 21:07 ` [EXTERNAL] " Ricardo Rivera-Matos
2020-08-17 19:17 ` [PATCH v1 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver Ricardo Rivera-Matos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818163653.GA3586878@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=r-rivera-matos@ti.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox