From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Reto Schneider <code@reto-schneider.ch>
Cc: linux-arm-kernel@lists.infradead.org,
Reto Schneider <reto.schneider@husqvarnagroup.com>,
Stefan Roese <sr@denx.de>,
Michael Zimmermann <michael.zimmermann@grandcentrix.net>,
Rob Herring <robh+dt@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: at91: Add GARDENA smart Gateway AT91SAM board
Date: Wed, 19 Aug 2020 12:51:16 +0200 [thread overview]
Message-ID: <20200819105116.GI4500@piout.net> (raw)
In-Reply-To: <02431938-63ac-7f90-d985-534bcd60aac2@reto-schneider.ch>
On 19/08/2020 11:04:48+0200, Reto Schneider wrote:
> Hi Alexandre,
>
> On 8/17/20 12:21 PM, Alexandre Belloni wrote:
> > Thank you for this submission.
>
> Thanks a lot for the feedback.
>
> I will send a v2.
>
> > Overall, I'm not convinced it is a good idea to start from
> > at91sam9x5ek.dtsi as it makes you dtb bigger than necessary but if you
> > want it that way, I'm fine with that.
>
> Because using at91sam9x5ek.dtsi saves some code (maintenance effort?!) I
> am willing to accept the extra binary size.
> However, if you think that this causes the maintenance efforts to be
> greater than when doing it your way, I'd be up for changing it.
>
I'd say at91sam9x5ek.dtsi has very little chances to change and even if
this is the case, it will probably not break your device tree but it is
still a possibility.
As said, I'll let you choose.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-08-19 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 17:19 [PATCH] ARM: at91: Add GARDENA smart Gateway AT91SAM board Reto Schneider
2020-08-17 10:21 ` Alexandre Belloni
2020-08-19 9:04 ` Reto Schneider
2020-08-19 10:51 ` Alexandre Belloni [this message]
2020-08-19 11:25 ` [PATCH v2] ARM: at91: Add GARDENA smart Gateway (Art. 19000) board Reto Schneider
2020-08-19 22:35 ` Rob Herring
2020-08-22 15:10 ` [PATCH v3 1/2] dt-bindings: arm: " Reto Schneider
2020-08-22 15:10 ` [PATCH v3 2/2] ARM: at91: Add GARDENA smart Gateway (Art. 19000) support Reto Schneider
2020-08-25 15:53 ` [PATCH v3 1/2] dt-bindings: arm: at91: Add GARDENA smart Gateway (Art. 19000) board Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819105116.GI4500@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=code@reto-schneider.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=michael.zimmermann@grandcentrix.net \
--cc=nicolas.ferre@microchip.com \
--cc=reto.schneider@husqvarnagroup.com \
--cc=robh+dt@kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).