From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41189C433DF for ; Wed, 19 Aug 2020 13:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AB58204FD for ; Wed, 19 Aug 2020 13:52:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WnncSTuU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728493AbgHSNw1 (ORCPT ); Wed, 19 Aug 2020 09:52:27 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:58396 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728393AbgHSNwY (ORCPT ); Wed, 19 Aug 2020 09:52:24 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6AC6829E; Wed, 19 Aug 2020 15:52:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1597845141; bh=w7VsKEZu0FsIH8x+aY7tucUSOSoA+yfIwMb6+M7XFP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WnncSTuUlrD92QfpZIWMrRn4ngkwQj5Rtn257Usln05G1XVZuDyAD8eYpbBmxULNU YqQuZvas/qEm5aCsNxZW0uGW0wSyp67VXk4pDK/gtxJs7MePy+BKJHmFVQJ+7Bxk0s C41sQwivq4mKa0ts3XUgumC0JhTRWaAAFxpCjJso= Date: Wed, 19 Aug 2020 16:52:04 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, "Lad, Prabhakar" , mchehab@kernel.org, sakari.ailus@linux.intel.com, hverkuil-cisco@xs4all.nl, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: media: ov772x: Convert to json-schema Message-ID: <20200819135204.GJ6049@pendragon.ideasonboard.com> References: <20200818122012.37956-1-jacopo+renesas@jmondi.org> <20200818122012.37956-2-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200818122012.37956-2-jacopo+renesas@jmondi.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jacopo, Thank you for the patch. On Tue, Aug 18, 2020 at 02:20:10PM +0200, Jacopo Mondi wrote: > Convert the ov772x binding document to json-schema and update > the MAINTAINERS file accordingly. > > Signed-off-by: Jacopo Mondi > --- > .../devicetree/bindings/media/i2c/ov772x.txt | 40 --------- > .../devicetree/bindings/media/i2c/ov772x.yaml | 84 +++++++++++++++++++ Could yuo rename this to ovti,ov772x.yaml ? > MAINTAINERS | 2 +- > 3 files changed, 85 insertions(+), 41 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov772x.txt > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov772x.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov772x.txt b/Documentation/devicetree/bindings/media/i2c/ov772x.txt > deleted file mode 100644 > index 0b3ede5b8e6a..000000000000 > --- a/Documentation/devicetree/bindings/media/i2c/ov772x.txt > +++ /dev/null > @@ -1,40 +0,0 @@ > -* Omnivision OV7720/OV7725 CMOS sensor > - > -The Omnivision OV7720/OV7725 sensor supports multiple resolutions output, > -such as VGA, QVGA, and any size scaling down from CIF to 40x30. It also can > -support the YUV422, RGB565/555/444, GRB422 or raw RGB output formats. > - > -Required Properties: > -- compatible: shall be one of > - "ovti,ov7720" > - "ovti,ov7725" > -- clocks: reference to the xclk input clock. > - > -Optional Properties: > -- reset-gpios: reference to the GPIO connected to the RSTB pin which is > - active low, if any. > -- powerdown-gpios: reference to the GPIO connected to the PWDN pin which is > - active high, if any. > - > -The device node shall contain one 'port' child node with one child 'endpoint' > -subnode for its digital output video port, in accordance with the video > -interface bindings defined in Documentation/devicetree/bindings/media/ > -video-interfaces.txt. > - > -Example: > - > -&i2c0 { > - ov772x: camera@21 { > - compatible = "ovti,ov7725"; > - reg = <0x21>; > - reset-gpios = <&axi_gpio_0 0 GPIO_ACTIVE_LOW>; > - powerdown-gpios = <&axi_gpio_0 1 GPIO_ACTIVE_LOW>; > - clocks = <&xclk>; > - > - port { > - ov772x_0: endpoint { > - remote-endpoint = <&vcap1_in0>; > - }; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/media/i2c/ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml > new file mode 100644 > index 000000000000..2b84fefeb4aa > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/ov772x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Omnivision OV7720/OV7725 CMOS sensor > + > +maintainers: > + - Jacopo Mondi > + > +description: -| > + The Omnivision OV7720/OV7725 sensor supports multiple resolutions output, > + such as VGA, QVGA, and any size scaling down from CIF to 40x30. It also can > + support the YUV422, RGB565/555/444, GRB422 or raw RGB output formats. > + > +properties: > + compatible: > + enum: > + - ovti,ov7720 > + - ovti,ov7725 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + reset-gpios: > + description: -| > + Reference to the GPIO connected to the RSTB pin which is active low. > + maxItems: 1 > + > + powerdown-gpios: > + description: -| > + Reference to the GPIO connected to the PWDN pin which is active high. > + maxItems: 1 > + > + port: > + type: object > + description: | > + The device node must contain one 'port' child node for its digital output > + video port, in accordance with the video interface bindings defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. You can simply write Digital input video port. See ../video-interfaces.txt. > + > + properties: > + endpoint: > + type: object > + properties: > + remote-endpoint: > + description: A phandle to the bus receiver's endpoint node. required: - remote-endpoint additionalProperties: false Reviewed-by: Laurent Pinchart > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + - reset-gpios > + - powerdown-gpios > + > +examples: > + - | > + #include > + > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + ov772x: camera@21 { > + compatible = "ovti,ov7725"; > + reg = <0x21>; > + reset-gpios = <&axi_gpio_0 0 GPIO_ACTIVE_LOW>; > + powerdown-gpios = <&axi_gpio_0 1 GPIO_ACTIVE_LOW>; > + clocks = <&xclk>; > + > + port { > + ov772x_0: endpoint { > + remote-endpoint = <&vcap1_in0>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index d1a6173d3b64..d0a20214eaaf 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12666,7 +12666,7 @@ M: Jacopo Mondi > L: linux-media@vger.kernel.org > S: Odd fixes > T: git git://linuxtv.org/media_tree.git > -F: Documentation/devicetree/bindings/media/i2c/ov772x.txt > +F: Documentation/devicetree/bindings/media/i2c/ov772x.yaml > F: drivers/media/i2c/ov772x.c > F: include/media/i2c/ov772x.h > -- Regards, Laurent Pinchart