From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23169C433E1 for ; Wed, 19 Aug 2020 22:30:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE9B7207DE for ; Wed, 19 Aug 2020 22:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597876236; bh=107X92WlWILbgg3oOEW9J2/g9CbOmsCMKO5aA8rXW+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=s8CKYe1cK69/J1hu9xycsa+xOykp8hnD0Cyn8gCXGt+WZ6JIMg1895W0n08ZEH4Cx iROzoQ0jjxzU0birgBUdYJSgLeZdOWG7oizKxaJYW4eIY+Eca5wvgtHODE/vLW8y4t A4nMQnuzBQO5ZvJd28rGO4jaVU52JhGAH7bStLZ4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbgHSWag (ORCPT ); Wed, 19 Aug 2020 18:30:36 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:39611 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726342AbgHSWaf (ORCPT ); Wed, 19 Aug 2020 18:30:35 -0400 Received: by mail-io1-f68.google.com with SMTP id z6so375913iow.6; Wed, 19 Aug 2020 15:30:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TPAgoF6CS6LHb79mBEQMdU6QynqQNT4ADYnbP9+wi74=; b=Iy3eq/WA8d3tP56uIU8z31H/+gJFoshRuzJlQVlwM8uC7l+yminCpJO5C1lxhPdqJr HExhMNpxUSYz1AwLaICvNTZp8ixGXIVH6DEntjlHJnM9qgOUhW+yRTe7AK6xPEYo54YY CwhIJwr/cjaZS4wIJs0K0Hz3JB5YOG1gKo5pFgHBSKScx0OWwJuBWAfrXFcDEk8/oumR JaB1O8ryX0Q8L/TuSfv6P78a9J/1HS3XGLeMjM5Sl1Hb9iWDG24/z6D15E+Yc9/1IYwx IcTf2o2SnahMKS8tyg4UeqY4C9+fnRJVpBQAOcAeZhN4Wn3V9z2FkzVWMfYr9RuLqTeh RFVQ== X-Gm-Message-State: AOAM531qUo+t6ZuP5PJ3Judh1M/u0Q35r0iGZUaiSS7h5YIEpajSKrWf PGNRrjZ9bZJx75dDHX/GPA== X-Google-Smtp-Source: ABdhPJzOVbOE3td6fQsaX3GtZOf+rgr1VvqINzVc5EPIlkHCXVE0LtV3YFDHep9Apf5exI1W+VesoQ== X-Received: by 2002:a02:8806:: with SMTP id r6mr533184jai.88.1597876234835; Wed, 19 Aug 2020 15:30:34 -0700 (PDT) Received: from xps15 ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id z26sm243083ilf.60.2020.08.19.15.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 15:30:34 -0700 (PDT) Received: (nullmailer pid 2077672 invoked by uid 1000); Wed, 19 Aug 2020 22:30:32 -0000 Date: Wed, 19 Aug 2020 16:30:31 -0600 From: Rob Herring To: Marc Zyngier Cc: Bjorn Helgaas , Jiaxun Yang , kernel-team@android.com, Heiko Stuebner , Frank Rowand , Rob Herring , devicetree@vger.kernel.org, Shawn Lin , linux-rockchip@lists.infradead.org, Lorenzo Pieralisi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2] of: address: Work around missing device_type property in pcie nodes Message-ID: <20200819223031.GA2077542@bogus> References: <20200819094255.474565-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819094255.474565-1-maz@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 19 Aug 2020 10:42:55 +0100, Marc Zyngier wrote: > Recent changes to the DT PCI bus parsing made it mandatory for > device tree nodes describing a PCI controller to have the > 'device_type = "pci"' property for the node to be matched. > > Although this follows the letter of the specification, it > breaks existing device-trees that have been working fine > for years. Rockchip rk3399-based systems are a prime example > of such collateral damage, and have stopped discovering their > PCI bus. > > In order to paper over it, let's add a workaround to the code > matching the device type, and accept as PCI any node that is > named "pcie", > > A warning will hopefully nudge the user into updating their > DT to a fixed version if they can, but the incentive is > obviously pretty small. > > Fixes: 2f96593ecc37 ("of_address: Add bus type match for pci ranges parser") > Suggested-by: Rob Herring > Signed-off-by: Marc Zyngier > --- > drivers/of/address.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > Applied, thanks!