From: Rob Herring <robh@kernel.org>
To: Reto Schneider <code@reto-schneider.ch>
Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Michael Zimmermann <michael.zimmermann@grandcentrix.net>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
open list <linux-kernel@vger.kernel.org>,
Kamel Bouhara <kamel.bouhara@bootlin.com>,
Cristian Birsan <cristian.birsan@microchip.com>,
Eugen Hristev <eugen.hristev@microchip.com>,
alexandre.belloni@bootlin.com,
linux-arm-kernel@lists.infradead.org, Stefan Roese <sr@denx.de>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Reto Schneider <reto.schneider@husqvarnagroup.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2] ARM: at91: Add GARDENA smart Gateway (Art. 19000) board
Date: Wed, 19 Aug 2020 16:35:30 -0600 [thread overview]
Message-ID: <20200819223530.GA2083518@bogus> (raw)
In-Reply-To: <20200819112550.16494-1-code@reto-schneider.ch>
On Wed, 19 Aug 2020 13:25:47 +0200, Reto Schneider wrote:
> From: Reto Schneider <reto.schneider@husqvarnagroup.com>
>
> This patch adds support for the GARDENA smart Gateway, which is based on
> the Atmel AT91SAM9G25. It is equipped with 128 MiB of DDR2 RAM and
> 256 MiB NAND storage.
>
> Please note that this gateway is not actually based on a AT91SAM9x5 EK
> board, but is close enough to allow its DT to be used.
>
> Co-developed-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Co-developed-by: Michael Zimmermann <michael.zimmermann@grandcentrix.net>
> Signed-off-by: Michael Zimmermann <michael.zimmermann@grandcentrix.net>
> Signed-off-by: Reto Schneider <reto.schneider@husqvarnagroup.com>
> ---
> .../devicetree/bindings/arm/atmel-at91.yaml | 2 +
> arch/arm/boot/dts/Makefile | 1 +
> .../dts/at91sam9g25-gardena-smart-gateway.dts | 157 ++++++++++++++++++
> 3 files changed, 160 insertions(+)
> create mode 100644 arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: properties:compatible:oneOf:2:items: [{'enum': ['overkiz,kizboxmini-base', 'overkiz,kizboxmini-mb', 'overkiz,kizboxmini-rd', 'overkiz,smartkiz', 'gardena,smart-gateway-at91sam"']}, {'const': 'atmel,at91sam9g25'}, {'const': 'atmel,at91sam9x5'}, {'const': 'atmel,at91sam9'}] is not valid under any of the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: properties:compatible:oneOf:2:items: [{'enum': ['overkiz,kizboxmini-base', 'overkiz,kizboxmini-mb', 'overkiz,kizboxmini-rd', 'overkiz,smartkiz', 'gardena,smart-gateway-at91sam"']}, {'const': 'atmel,at91sam9g25'}, {'const': 'atmel,at91sam9x5'}, {'const': 'atmel,at91sam9'}] is not of type 'object'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: properties:compatible:oneOf:2:items:0:enum:4: 'gardena,smart-gateway-at91sam"' does not match '^[a-zA-Z0-9,.\\-_ #+/]+$'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: ignoring, error in schema: properties: compatible: oneOf: 2: items
warning: no schema found in file: ./Documentation/devicetree/bindings/arm/atmel-at91.yaml
See https://patchwork.ozlabs.org/patch/1347723
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-08-19 22:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 17:19 [PATCH] ARM: at91: Add GARDENA smart Gateway AT91SAM board Reto Schneider
2020-08-17 10:21 ` Alexandre Belloni
2020-08-19 9:04 ` Reto Schneider
2020-08-19 10:51 ` Alexandre Belloni
2020-08-19 11:25 ` [PATCH v2] ARM: at91: Add GARDENA smart Gateway (Art. 19000) board Reto Schneider
2020-08-19 22:35 ` Rob Herring [this message]
2020-08-22 15:10 ` [PATCH v3 1/2] dt-bindings: arm: " Reto Schneider
2020-08-22 15:10 ` [PATCH v3 2/2] ARM: at91: Add GARDENA smart Gateway (Art. 19000) support Reto Schneider
2020-08-25 15:53 ` [PATCH v3 1/2] dt-bindings: arm: at91: Add GARDENA smart Gateway (Art. 19000) board Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819223530.GA2083518@bogus \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=code@reto-schneider.ch \
--cc=codrin.ciubotariu@microchip.com \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=michael.zimmermann@grandcentrix.net \
--cc=reto.schneider@husqvarnagroup.com \
--cc=robh+dt@kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).