Re: [PATCH 7/7] [NOT FOR MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable OV8865 camera

Maxime Ripard
2020-08-25T14:40:34Z

Hi,

On Fri, Aug 21, 2020 at 04:59:35PM +0200, Kévin L'hôpital wrote:
> The Bananapi M3 supports a camera module which includes an
> OV8865 sensor connected via the parallel CSI interface and
> an OV8865 sensor connected via MIPI CSI-2.
>
> The I2C2 bus is shared by the two sensors as well as active-low
> reset signal but each sensor has it own shutdown line.
>
> The I2c address for the OV8865 is 0x36.
>
> The bus type is hardcoded to 4 due to the lack of available
> define usable in the device-tree.
>
> Signed-off-by: Kévin L'hôpital <kevin.lhopital@bootlin.com>
>
> ---
> arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 99 ++++++++++++++++++++
> 1 file changed, 99 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts
> index 9d34eabba121..f7839094695e 100644
> --- a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts
> +++ b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts
> @@ -85,6 +85,38 @@
> };
> };
>
> + reg_ov8865_avdd: ov8865-avdd {
> + compatible = "regulator-fixed";
> + regulator-name = "ov8865-avdd";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + vin-supply = <&reg_dldo4>;
> + };
> +
> + reg_ov8865_dovdd: ov8865-dovdd {
> + compatible = "regulator-fixed";
> + regulator-name = "ov8865-dovdd";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + vin-supply = <&reg_dldo4>;
> + };
> +
> + reg_ov8865_afvdd: ov8865-afvdd {
> + compatible = "regulator-fixed";
> + regulator-name = "ov8865-afvdd";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + vin-supply = <&reg_dldo4>;
> + };
> +
> + reg_ov8865_vdd2: ov8865-vdd2 {
> + compatible = "regulator-fixed";
> + regulator-name = "ov8865-vdd2";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + vin-supply = <&reg_eldo1>;
> + };
> +
> reg_usb1_vbus: reg-usb1-vbus {
> compatible = "regulator-fixed";
> regulator-name = "usb1-vbus";
> @@ -115,10 +147,59 @@
> cpu-supply = <&reg_dcdc3>;
> };
>
> +&ccu {
> + assigned-clocks = <&ccu CLK_CSI_MCLK>;
> + assigned-clock-parents = <&osc24M>;
> + assigned-clock-rates = <24000000>;
> +};

Why do you need to use assigned-clocks here?

> +&csi {
> + pinctrl-names = "default";
> + status = "okay";
> +};

pinctrl-names alone is useless

> +
> +&csi_in {
> + mipi_csi2_from_ov8865: endpoint {
> + remote-endpoint = <&ov8865_to_mipi_csi2>;
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + bus-type = <4>;
> + };
> +};
> +
> &de {
> status = "okay";
> };
>
> +&i2c2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c2_pe_pins>;
> + status = "okay";
> +
> + ov8865: camera@36 {
> + compatible = "ovti,ov8865";
> + reg = <0x36>;
> + clocks = <&ccu CLK_CSI_MCLK>;
> + clock-names ="xclk";
> + AVDD-supply = <&reg_ov8865_avdd>;
> + DOVDD-supply = <&reg_ov8865_dovdd>;
> + VDD2-supply = <&reg_ov8865_vdd2>;
> + AFVDD-supply = <&reg_ov8865_afvdd>;
> + powerdown-gpios = <&pio 4 17 GPIO_ACTIVE_LOW>; /* PE17 */
> + reset-gpios = <&pio 4 16 GPIO_ACTIVE_LOW>; /* PE16 */
> + rotation = <180>;
> +
> + port {
> + ov8865_to_mipi_csi2: endpoint {
> + remote-endpoint = <&mipi_csi2_from_ov8865>;
> + data-lanes = <1 2 3 4>;
> + clock-lanes = <0>;
> + bus-type = <4>; /* V4L2_FWNODE_BUS_TYPE_CSI2_DPHY */
> + };
> + };
> + };
> +};
> +
> &ehci0 {
> /* Terminus Tech FE 1.1s 4-port USB 2.0 hub here */
> status = "okay";
> @@ -191,6 +272,11 @@
> status = "okay";
> };
>
> +&pio {
> + pinctrl-names = "default";
> + pinctrl-0 = <&csi_mclk_pin>;
> +};

I'm not sure why you'd need to use the MCLK pin as a hog, assigning it
to the camera device should be enough?

Maxime