Re: [PATCH 1/7] media: sun6i-csi: Fix the bpp for 10-bit bayer formats

Kévin L'hôpital
2020-08-26T09:19:00Z

Hello,

Le Tue, 25 Aug 2020 23:50:30 +0800,
Chen-Yu Tsai <wens@csie.org> a écrit :

> On Fri, Aug 21, 2020 at 11:00 PM Kévin L'hôpital
> <kevin.lhopital@bootlin.com> wrote:
> >
> > 10-bit bayer formats are aligned to 16 bits in memory, so this is
> > what needs to be used as bpp for calculating the size of the
> > buffers to allocate.
> >
> > Signed-off-by: Kévin L'hôpital <kevin.lhopital@bootlin.com>
>
> Please add:
>
> Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI
> V3s")
>
>
I will add this, thank you very much for the review.
Kévin
>
> > ---
> > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> > b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h index
> > c626821aaedb..8b83d15de0d0 100644 ---
> > a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h +++
> > b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h @@ -100,7
> > +100,7 @@ static inline int sun6i_csi_get_bpp(unsigned int
> > pixformat) case V4L2_PIX_FMT_SGBRG10: case V4L2_PIX_FMT_SGRBG10:
> > case V4L2_PIX_FMT_SRGGB10:
> > - return 10;
> > + return 16;
> > case V4L2_PIX_FMT_SBGGR12:
> > case V4L2_PIX_FMT_SGBRG12:
> > case V4L2_PIX_FMT_SGRBG12:
> > --
> > 2.17.1
> >

--
Kevin L'Hopital, Bootlin
Embedded Linux and kernel engineering