Re: [PATCH 0/7] Support of MIPI CSI-2 for A83T and OV8865 camera

Kévin L'hôpital
2020-08-25T15:20:40Z

Le Mon, 24 Aug 2020 18:52:44 +0200,
Maxime Ripard <maxime@cerno.tech> a écrit :

> Hi,
>
> On Fri, Aug 21, 2020 at 04:59:28PM +0200, Kévin L'hôpital wrote:
> >
> > Kévin L'hôpital (7):
> > media: sun6i-csi: Fix the bpp for 10-bit bayer formats
> > dt-bindings: media: i2c: Add documentation for ov8865
> > media: i2c: Add support for the OV8865 image sensor
> > media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the
> > common header
> > media: sunxi: sun6i-csi: Add support of MIPI CSI-2 for A83T
> > ARM: dts: sun8i: a83t: Add support for the MIPI CSI-2 in CSI node
> > [NOT FOR MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable OV8865
> > camera
>
> You should have a cover letter here to provide some context.
>
> There's a bunch of things that would need to be explained and / or
> argued for here, in particular:
> - Why did you need to plumb it into sun6i-csi?
> - You're naming the CSI part as the A83t CSI, while MIPI-CSI has
> been supported since the A31(?), is there a reason for that?
> - This is not documented anywhere, what did you base this work on?
>
> Also, I think that documenting the general challenges you faced (which
> were likely because of the first bullet point above) and how you
> solved them here would be great to start a discussion if needed.
>
> Finally, iirc, Hans requires a v4l2-compliance run for any new driver,
> which isn't strictly the case for this driver, but isn't really *not*
> the case either.
>
> Maxime

Thank you very much for the review, I will add all this context.

Kévin

--
Kevin L'Hopital, Bootlin
Embedded Linux and kernel engineering