Re: [PATCH v4 2/3] dt-bindings: mfd: add LP87524-Q1

[Rob Herring <robh@kernel.org>]

On Mon, Aug 17, 2020 at 04:50:17PM +0200, Luca Ceresoli wrote:
> Add the LP87524-Q1 to the bindings along with an example. This is a variant
> of the LP87565-Q1 and LP87561-Q1 chips which already have bindings.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> 
> ---
> 
> Changes in v4:
>  - reformat as a standalone file
> 
> Changes in v3:
>  - fix yaml errors
> 
> Changes in v2:
>  - RFC,v1 was based on the txt file, rewrite for yaml
>  - use uppercase consistently in model names (Lee Jones)
>  - replace "regulator" -> "mfd" in subject line (Lee Jones)
>  - replace "dt:" suffix with "dt-bindings:" prefix in subject line
> ---
>  .../bindings/mfd/ti,lp87524-q1.yaml           | 105 ++++++++++++++++++
>  1 file changed, 105 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml b/Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml
> new file mode 100644
> index 000000000000..1193fcb19739
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,lp87524-q1.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,lp87524-q1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI LP87524-Q1 four 1-phase output buck converter
> +
> +maintainers:
> +  - Keerthy <j-keerthy@ti.com>
> +
> +properties:
> +  compatible:
> +    const: ti,lp87524-q1
> +
> +  reg:
> +    description: I2C slave address
> +    const: 0x60
> +
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    description:
> +      The first cell is the pin number.
> +      The second cell is is used to specify flags.
> +      See ../gpio/gpio.txt for more information.
> +    const: 2
> +
> +  buck0-in-supply:
> +    description:
> +      Phandle to parent supply node for the BUCK0 converter.
> +
> +  buck1-in-supply:
> +    description:
> +      Phandle to parent supply node for the BUCK1 converter.
> +
> +  buck2-in-supply:
> +    description:
> +      Phandle to parent supply node for the BUCK2 converter.
> +
> +  buck3-in-supply:
> +    description:
> +      Phandle to parent supply node for the BUCK3 converter.
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - '#gpio-cells'
> +  - buck0-in-supply
> +  - buck1-in-supply
> +  - buck2-in-supply
> +  - buck3-in-supply
> +
> +examples:
> +  - |
> +    i2c@0 {
> +        reg = <0x0 0x100>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pmic@60 {
> +            compatible = "ti,lp87524-q1";
> +            reg = <0x60>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
> +
> +            buck0-in-supply = <&vdd_5v0>;
> +            buck1-in-supply = <&vdd_5v0>;
> +            buck2-in-supply = <&vdd_5v0>;
> +            buck3-in-supply = <&vdd_5v0>;
> +
> +            regulators {
> +                buck0_reg: buck0 {

Here too, you need to describe all this.

> +                    regulator-name = "buck0";
> +                    regulator-min-microvolt = <3300000>;
> +                    regulator-max-microvolt = <3300000>;
> +                    regulator-always-on;
> +                };
> +
> +                buck1_reg: buck1 {
> +                    regulator-name = "buck1";
> +                    regulator-min-microvolt = <1350000>;
> +                    regulator-max-microvolt = <1350000>;
> +                    regulator-always-on;
> +                };
> +
> +                buck2_reg: buck2 {
> +                    regulator-name = "buck2";
> +                    regulator-min-microvolt = <950000>;
> +                    regulator-max-microvolt = <950000>;
> +                    regulator-always-on;
> +                };
> +
> +                buck3_reg: buck3 {
> +                    regulator-name = "buck3";
> +                    regulator-min-microvolt = <1800000>;
> +                    regulator-max-microvolt = <1800000>;
> +                    regulator-always-on;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> -- 
> 2.28.0
>