From: Rob Herring <robh@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Patrick Lai <plai@codeaurora.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: qcom: Document "aux-devs" property
Date: Tue, 25 Aug 2020 15:52:53 -0600 [thread overview]
Message-ID: <20200825215253.GA1397515@bogus> (raw)
In-Reply-To: <20200819091533.2334-2-stephan@gerhold.net>
On Wed, Aug 19, 2020 at 11:15:32AM +0200, Stephan Gerhold wrote:
> In some cases we need to probe additional audio components that do
> not appear as part of the DAI links specified in the device tree.
> Examples for this are auxiliary devices such as analog amplifiers
> or codecs.
>
> To make them work they need to be added as part of "aux-devs"
> and connected to some other audio component using the audio routes
> configurable using "(qcom,)audio-routing".
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> .../devicetree/bindings/sound/qcom,apq8016-sbc.txt | 7 +++++++
> Documentation/devicetree/bindings/sound/qcom,apq8096.txt | 8 ++++++++
> Documentation/devicetree/bindings/sound/qcom,sdm845.txt | 8 ++++++++
> 3 files changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8016-sbc.txt b/Documentation/devicetree/bindings/sound/qcom,apq8016-sbc.txt
> index 84b28dbe9f15..23998262a0a7 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,apq8016-sbc.txt
> +++ b/Documentation/devicetree/bindings/sound/qcom,apq8016-sbc.txt
> @@ -34,6 +34,13 @@ Required properties:
> * DMIC
> * Ext Spk
>
> +Optional properties:
> +
> +- aux-devs : A list of phandles for auxiliary devices (e.g. analog
> + amplifiers) that do not appear directly within the DAI
> + links. Should be connected to another audio component
> + using "qcom,audio-routing".
> +
> Dai-link subnode properties and subnodes:
>
> Required dai-link subnodes:
> diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096.txt b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt
> index c814e867850f..248df5056fec 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,apq8096.txt
> +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt
> @@ -55,6 +55,14 @@ This binding describes the APQ8096 sound card, which uses qdsp for audio.
> Value type: <stringlist>
> Definition: The user-visible name of this sound card.
>
> +- aux-devs
> + Usage: optional
> + Value type: <phandles with arguments>
How do you know how many arguments? It either has to be fixed or needs a
#.*cells in the phandles. For the latter, you'd need to come up with a
common binding.
> + Definition: A list of phandles for auxiliary devices (e.g. analog
> + amplifiers) that do not appear directly within the DAI
> + links. Should be connected to another audio component
> + using "audio-routing".
> +
> = dailinks
> Each subnode of sndcard represents either a dailink, and subnodes of each
> dailinks would be cpu/codec/platform dais.
> diff --git a/Documentation/devicetree/bindings/sound/qcom,sdm845.txt b/Documentation/devicetree/bindings/sound/qcom,sdm845.txt
> index ca8c89e88bfa..3d5cbe953cf7 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,sdm845.txt
> +++ b/Documentation/devicetree/bindings/sound/qcom,sdm845.txt
> @@ -24,6 +24,14 @@ This binding describes the SDM845 sound card, which uses qdsp for audio.
> Value type: <stringlist>
> Definition: The user-visible name of this sound card.
>
> +- aux-devs
> + Usage: optional
> + Value type: <phandles with arguments>
> + Definition: A list of phandles for auxiliary devices (e.g. analog
> + amplifiers) that do not appear directly within the DAI
> + links. Should be connected to another audio component
> + using "audio-routing".
> +
> = dailinks
> Each subnode of sndcard represents either a dailink, and subnodes of each
> dailinks would be cpu/codec/platform dais.
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-08-25 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 9:15 [PATCH 0/2] ASoC: qcom: common: Parse auxiliary devices from device tree Stephan Gerhold
2020-08-19 9:15 ` [PATCH 1/2] ASoC: dt-bindings: qcom: Document "aux-devs" property Stephan Gerhold
2020-08-25 21:52 ` Rob Herring [this message]
2020-08-26 8:41 ` Stephan Gerhold
2020-08-19 9:15 ` [PATCH 2/2] ASoC: qcom: common: Parse auxiliary devices from device tree Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825215253.GA1397515@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).