From: Rob Herring <robh@kernel.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
jslaby@suse.com, git-dev@xilinx.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/2] bindings: serial: Add xilinx compatible
Date: Tue, 25 Aug 2020 16:12:47 -0600 [thread overview]
Message-ID: <20200825221247.GA1429623@bogus> (raw)
In-Reply-To: <1597855439-746-1-git-send-email-shubhrajyoti.datta@xilinx.com>
On Wed, Aug 19, 2020 at 10:13:58PM +0530, Shubhrajyoti Datta wrote:
> Add the arm,xlnx-sbsa-uart compatible.
> Xilinx versal uart is similar to sbsa-uart except that it has
> termios configurable.
Yet still not just a pl011? Sigh.
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> Documentation/devicetree/bindings/serial/pl011.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml
> index c23c93b..6e123b1 100644
> --- a/Documentation/devicetree/bindings/serial/pl011.yaml
> +++ b/Documentation/devicetree/bindings/serial/pl011.yaml
> @@ -20,6 +20,7 @@ select:
> enum:
> - arm,pl011
> - zte,zx296702-uart
> + - arm,xlnx-sbsa-uart
> required:
> - compatible
>
> @@ -32,6 +33,7 @@ properties:
> - items:
> - const: zte,zx296702-uart
> - const: arm,primecell
> + - const: arm,xlnx-sbsa-uart
You are defining compatible must be:
compatible = "zte,zx296702-uart", "arm,primecell", "arm,xlnx-sbsa-uart";
Probably not what you want. And breaks ZTE.
next prev parent reply other threads:[~2020-08-25 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 16:43 [PATCH 1/2] bindings: serial: Add xilinx compatible Shubhrajyoti Datta
2020-08-19 16:43 ` [PATCH 2/2] tty: pl011: Add support for xilinx uart Shubhrajyoti Datta
2020-08-25 22:17 ` Rob Herring
2020-08-25 22:12 ` Rob Herring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-19 16:42 [PATCH 1/2] bindings: serial: Add xilinx compatible Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825221247.GA1429623@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git-dev@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-serial@vger.kernel.org \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).