Re: [PATCH v1 2/2] drm: bridge: add support for lontium LT9611UXC bridge

Dmitry Baryshkov
2020-08-28T15:02:28Z

On 28/08/2020 17:18, Vinod Koul wrote:
> On 28-08-20, 15:04, Dmitry Baryshkov wrote:
>> +static int lt9611uxc_bridge_attach(struct drm_bridge *bridge,
>> + enum drm_bridge_attach_flags flags)
>> +{
>> + struct lt9611uxc *lt9611uxc = bridge_to_lt9611uxc(bridge);
>> + int ret;
>> +
>> + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
>> + dev_err(lt9611uxc->dev, "Fix bridge driver to make connector optional!");
>
> Can we support both modes as I have done in lt9611, that way once the
> conversion is done we can drop the init part and support conversion.
>
> I have patch for msm driver to set DRM_BRIDGE_ATTACH_NO_CONNECTOR, you
> can use that to test

Probably the message text is misleading. The driver as is does not work
w/o DRM_BRIDGE_ATTACH_NO_CONNECTOR. Do you plan to push that patch into
upstream tree?

>> +static int lt9611uxc_hdmi_hw_params(struct device *dev, void *data,
>> + struct hdmi_codec_daifmt *fmt,
>> + struct hdmi_codec_params *hparms)
>> +{
>> + /*
>> + * LT9611UXC will automatically detect rate and sample size, so no need
>> + * to setup anything here.
>> + */
>> + return 0;
>> +}
>
> Do we need dummy function?

Yes, this callback is mandatory (and audio_shutdown).

--
With best wishes
Dmitry