devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH mmc-next v3 1/2] dt-bindings: mmc: add alias example
Date: Fri, 28 Aug 2020 16:24:40 -0600	[thread overview]
Message-ID: <20200828222440.GA3507259@bogus> (raw)
In-Reply-To: <20200825134441.17537-1-matthias.schiffer@ew.tq-group.com>

On Tue, Aug 25, 2020 at 03:44:40PM +0200, Matthias Schiffer wrote:
> As for I2C and SPI, it now is possible to reserve a fixed index for
> mmc/mmcblk devices.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
> 
> v3: new patch
> 
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index b96da0c7f819..22ed4a36c65d 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -367,6 +367,14 @@ examples:
>      };
>  
>    - |
> +    /*
> +     * Optionally define an alias to reserve a fixed index for the
> +     * mmc and mmcblk devices
> +     */
> +    aliases {
> +        mmc0 = &mmc3;
> +    };

This will break if we improve schemas because this node is actually 
/example-1/aliases.

So please drop. If you want, I'd really like to have a defined set (i.e. 
a schema) of alias names. This would require deleting a bunch on some 
platforms that just made up a bunch of them.

> +
>      mmc3: mmc@1c12000 {
>          #address-cells = <1>;
>          #size-cells = <0>;
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2020-08-28 22:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 13:44 [PATCH mmc-next v3 1/2] dt-bindings: mmc: add alias example Matthias Schiffer
2020-08-25 13:44 ` [PATCH mmc-next v3 2/2] mmc: allow setting slot index via device tree alias Matthias Schiffer
2020-08-28 22:24 ` Rob Herring [this message]
2020-08-31  7:58   ` [PATCH mmc-next v3 1/2] dt-bindings: mmc: add alias example Matthias Schiffer
2020-08-31  9:16     ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828222440.GA3507259@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=s.hauer@pengutronix.de \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).