From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF99C433E2 for ; Sat, 29 Aug 2020 10:00:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF2C520838 for ; Sat, 29 Aug 2020 10:00:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727793AbgH2KAe (ORCPT ); Sat, 29 Aug 2020 06:00:34 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35689 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbgH2KAd (ORCPT ); Sat, 29 Aug 2020 06:00:33 -0400 X-Originating-IP: 2.224.242.101 Received: from uno.localdomain (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AB400FF804; Sat, 29 Aug 2020 10:00:27 +0000 (UTC) Date: Sat, 29 Aug 2020 12:04:13 +0200 From: Jacopo Mondi To: Rob Herring Cc: Jacopo Mondi , devicetree@vger.kernel.org, linux-media@vger.kernel.org, Leon Luo , mchehab@kernel.org, sakari.ailus@linux.intel.com, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3] dt-bindings: media: imx274: Convert to json-schema Message-ID: <20200829100413.75mpuntlezfknqts@uno.localdomain> References: <20200824105850.28002-1-jacopo+renesas@jmondi.org> <20200828221225.GA3491712@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200828221225.GA3491712@bogus> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Fri, Aug 28, 2020 at 04:12:25PM -0600, Rob Herring wrote: > On Mon, Aug 24, 2020 at 12:58:50PM +0200, Jacopo Mondi wrote: > > Convert the imx274 bindings document to json-schema and update > > the MAINTAINERS file accordingly. > > > > Reviewed-by: Laurent Pinchart > > Signed-off-by: Jacopo Mondi > > --- > > .../devicetree/bindings/media/i2c/imx274.txt | 38 ----------- > > .../bindings/media/i2c/sony,imx274.yaml | 68 +++++++++++++++++++ > > MAINTAINERS | 2 +- > > 3 files changed, 69 insertions(+), 39 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt > > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt > > deleted file mode 100644 > > index 0727079d2410..000000000000 > > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt > > +++ /dev/null > > @@ -1,38 +0,0 @@ > > -* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor > > - > > -The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with > > -an active array size of 3864H x 2202V. It is programmable through I2C > > -interface. The I2C address is fixed to 0x1a as per sensor data sheet. > > -Image data is sent through MIPI CSI-2, which is configured as 4 lanes > > -at 1440 Mbps. > > - > > - > > -Required Properties: > > -- compatible: value should be "sony,imx274" for imx274 sensor > > -- reg: I2C bus address of the device > > - > > -Optional Properties: > > -- reset-gpios: Sensor reset GPIO > > -- clocks: Reference to the input clock. > > -- clock-names: Should be "inck". > > -- VANA-supply: Sensor 2.8v analog supply. > > -- VDIG-supply: Sensor 1.8v digital core supply. > > -- VDDL-supply: Sensor digital IO 1.2v supply. > > - > > -The imx274 device node should contain one 'port' child node with > > -an 'endpoint' subnode. For further reading on port node refer to > > -Documentation/devicetree/bindings/media/video-interfaces.txt. > > - > > -Example: > > - sensor@1a { > > - compatible = "sony,imx274"; > > - reg = <0x1a>; > > - #address-cells = <1>; > > - #size-cells = <0>; > > - reset-gpios = <&gpio_sensor 0 0>; > > - port { > > - sensor_out: endpoint { > > - remote-endpoint = <&csiss_in>; > > - }; > > - }; > > - }; > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml > > new file mode 100644 > > index 000000000000..7ae47a614d2e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml > > @@ -0,0 +1,68 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor > > + > > +maintainers: > > + - Leon Luo > > + > > +description: -| > > + The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an > > + active array size of 3864H x 2202V. It is programmable through I2C interface. > > + Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440 > > + Mbps. > > + > > +properties: > > + compatible: > > + const: sony,imx274 > > + > > + reg: > > + const: 0x1a > > + > > + reset-gpios: > > + maxItems: 1 > > + > > + port: > > + type: object > > + description: | > > + The device node must contain one 'port' child node for its digital output > > + video port, in accordance with the video interface bindings defined in > > + Documentation/devicetree/bindings/media/video-interfaces.txt. > > + > > + properties: > > + endpoint: > > + type: object > > + properties: > > + remote-endpoint: > > + description: A phandle to the bus receiver's endpoint node. > > As discussed, drop 'endpoint'. > Yes indeed. Discussion has been finalized after I sent this one out. Same for the mt9v111 bindings you can skip review of. I'll drop endpoint and defer it to a future of-graph.yaml Thanks j > > + > > + additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - port > > additionalProperties: false > > > + > > +examples: > > + - | > > + i2c0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + imx274: camera-sensor@1a { > > + compatible = "sony,imx274"; > > + reg = <0x1a>; > > + reset-gpios = <&gpio_sensor 0 0>; > > + > > + port { > > + sensor_out: endpoint { > > + remote-endpoint = <&csiss_in>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 9503ea17aa28..dc7b1ea8e7b3 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -16125,7 +16125,7 @@ M: Leon Luo > > L: linux-media@vger.kernel.org > > S: Maintained > > T: git git://linuxtv.org/media_tree.git > > -F: Documentation/devicetree/bindings/media/i2c/imx274.txt > > +F: Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml > > F: drivers/media/i2c/imx274.c > > > > SONY IMX290 SENSOR DRIVER > > -- > > 2.27.0 > >