From: Sam Ravnborg <sam@ravnborg.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Hoegeun Kwon <hoegeun.kwon@samsung.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: display: samsung,amoled-mipi-dsi: Do not require enable-gpios on samsung,s6e63j0x03
Date: Sat, 29 Aug 2020 23:06:52 +0200 [thread overview]
Message-ID: <20200829210652.GD796939@ravnborg.org> (raw)
In-Reply-To: <20200829172532.29358-1-krzk@kernel.org>
On Sat, Aug 29, 2020 at 07:25:29PM +0200, Krzysztof Kozlowski wrote:
> The samsung,s6e63j0x03 does not have enable GPIO, so do not require it.
> This fixes dtbs_check warning:
>
> arch/arm/boot/dts/exynos3250-rinato.dt.yaml: panel@0: 'enable-gpios' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
I expect this patch is picked up with the dts fixes.
Sam
> ---
> .../display/panel/samsung,amoled-mipi-dsi.yaml | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml
> index 96bdde9298e0..ccc482570d6a 100644
> --- a/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,amoled-mipi-dsi.yaml
> @@ -12,6 +12,17 @@ maintainers:
> allOf:
> - $ref: panel-common.yaml#
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - samsung,s6e3ha2
> + - samsung,s6e3hf2
> + then:
> + required:
> + - enable-gpios
> +
> properties:
> compatible:
> enum:
> @@ -39,7 +50,6 @@ required:
> - vdd3-supply
> - vci-supply
> - reset-gpios
> - - enable-gpios
>
> additionalProperties: false
>
> --
> 2.17.1
next prev parent reply other threads:[~2020-08-29 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 17:25 [PATCH 1/4] dt-bindings: display: samsung,amoled-mipi-dsi: Do not require enable-gpios on samsung,s6e63j0x03 Krzysztof Kozlowski
2020-08-29 17:25 ` [RFT 2/4] ARM: dts: exynos: Move fixed clocks under root node in Exynos3250 Krzysztof Kozlowski
2020-08-31 11:03 ` Marek Szyprowski
2020-09-01 10:15 ` Krzysztof Kozlowski
2020-08-29 17:25 ` [RFT 3/4] ARM: dts: exynos: Move CMU assigned ISP clocks to buses " Krzysztof Kozlowski
2020-08-31 8:11 ` Marek Szyprowski
2020-08-31 8:19 ` Krzysztof Kozlowski
2020-08-31 8:29 ` Marek Szyprowski
2020-08-31 8:31 ` Krzysztof Kozlowski
2020-08-29 17:25 ` [PATCH 4/4] ARM: dts: exynos: Remove snps,dwc2 compatible " Krzysztof Kozlowski
2020-09-02 15:35 ` Krzysztof Kozlowski
2020-08-29 21:06 ` Sam Ravnborg [this message]
2020-09-14 18:16 ` [PATCH 1/4] dt-bindings: display: samsung, amoled-mipi-dsi: Do not require enable-gpios on samsung, s6e63j0x03 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829210652.GD796939@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=b.zolnierkie@samsung.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoegeun.kwon@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=snawrocki@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).