Re: [PATCH v9 2/3] drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4397 bytes --]

Hi Swapnil,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.9-rc3 next-20200828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Swapnil-Jakhade/drm-Add-support-for-Cadence-MHDP8546-DPI-DP-bridge-and-J721E-wrapper/20200831-162549
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/err.h:5,
                    from include/linux/clk.h:12,
                    from drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:22:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_fill_host_caps':
>> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:1355:2: error: implicit declaration of function 'phy_get_attrs' [-Werror=implicit-function-declaration]
    1355 |  phy_get_attrs(mhdp->phy, &attrs);
         |  ^~~~~~~~~~~~~
>> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:1361:19: error: 'struct phy_attrs' has no member named 'max_link_rate'
    1361 |  link_rate = attrs.max_link_rate;
         |                   ^
   cc1: some warnings being treated as errors

# https://github.com/0day-ci/linux/commit/f9a2fb8569e017b7eaba3a94afc9581179c2b62b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Swapnil-Jakhade/drm-Add-support-for-Cadence-MHDP8546-DPI-DP-bridge-and-J721E-wrapper/20200831-162549
git checkout f9a2fb8569e017b7eaba3a94afc9581179c2b62b
vim +/phy_get_attrs +1355 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c

  1348	
  1349	static void cdns_mhdp_fill_host_caps(struct cdns_mhdp_device *mhdp)
  1350	{
  1351		unsigned int link_rate;
  1352		struct phy_attrs attrs;
  1353	
  1354		/* Get source capabilities based on PHY attributes */
> 1355		phy_get_attrs(mhdp->phy, &attrs);
  1356	
  1357		mhdp->host.lanes_cnt = attrs.bus_width;
  1358		if (!mhdp->host.lanes_cnt)
  1359			mhdp->host.lanes_cnt = 4;
  1360	
> 1361		link_rate = attrs.max_link_rate;
  1362		if (!link_rate)
  1363			link_rate = drm_dp_bw_code_to_link_rate(DP_LINK_BW_8_1);
  1364		else
  1365			/* PHY uses Mb/s, DRM uses tens of kb/s. */
  1366			link_rate *= 100;
  1367	
  1368		mhdp->host.link_rate = link_rate;
  1369		mhdp->host.volt_swing = CDNS_VOLT_SWING(3);
  1370		mhdp->host.pre_emphasis = CDNS_PRE_EMPHASIS(3);
  1371		mhdp->host.pattern_supp = CDNS_SUPPORT_TPS(1) |
  1372					  CDNS_SUPPORT_TPS(2) | CDNS_SUPPORT_TPS(3) |
  1373					  CDNS_SUPPORT_TPS(4);
  1374		mhdp->host.lane_mapping = CDNS_LANE_MAPPING_NORMAL;
  1375		mhdp->host.fast_link = false;
  1376		mhdp->host.enhanced = true;
  1377		mhdp->host.scrambler = true;
  1378		mhdp->host.ssc = false;
  1379	}
  1380	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 57817 bytes --]