[PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Krzysztof Kozlowski]

The "sound-dai" property has cells therefore phandle-array should be
used, even if it is just one phandle.  This fixes dtbs_check warnings
like:

  arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0
  arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/sound/samsung,midas-audio.yaml      | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
index 1c755de686f7..578928e67e5c 100644
--- a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
+++ b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
@@ -21,7 +21,8 @@ properties:
     type: object
     properties:
       sound-dai:
-        $ref: /schemas/types.yaml#/definitions/phandle
+        $ref: /schemas/types.yaml#/definitions/phandle-array
+        maxItems: 1
         description: phandle to the I2S controller
     required:
       - sound-dai
@@ -30,7 +31,8 @@ properties:
     type: object
     properties:
       sound-dai:
-        $ref: /schemas/types.yaml#/definitions/phandle
+        $ref: /schemas/types.yaml#/definitions/phandle-array
+        maxItems: 1
         description: phandle to the WM1811 CODEC
     required:
       - sound-dai
-- 
2.17.1

[PATCH 2/2] dt-bindings: sound: odroid: Use unevaluatedProperties

[Krzysztof Kozlowski]

Additional properties or nodes actually might appear (e.g.
assigned-clocks) so use unevaluatedProperties to fix dtbs_check warnings
like:

  arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: sound:
    'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/sound/samsung,odroid.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/samsung,odroid.yaml b/Documentation/devicetree/bindings/sound/samsung,odroid.yaml
index 8ff2d39e7d17..de1be3d6d1e9 100644
--- a/Documentation/devicetree/bindings/sound/samsung,odroid.yaml
+++ b/Documentation/devicetree/bindings/sound/samsung,odroid.yaml
@@ -69,7 +69,7 @@ required:
   - cpu
   - codec
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.17.1

Re: [PATCH 2/2] dt-bindings: sound: odroid: Use unevaluatedProperties

[Sylwester Nawrocki]

On 30.08.2020 13:26, Krzysztof Kozlowski wrote:
> Additional properties or nodes actually might appear (e.g.
> assigned-clocks) so use unevaluatedProperties to fix dtbs_check warnings
> like:
> 
>   arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: sound:
>     'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Sylwester Nawrocki]

On 30.08.2020 13:26, Krzysztof Kozlowski wrote:
> The "sound-dai" property has cells therefore phandle-array should be
> used, even if it is just one phandle.  This fixes dtbs_check warnings
> like:
> 
>   arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0
>   arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

On Sun, Aug 30, 2020 at 01:26:32PM +0200, Krzysztof Kozlowski wrote:
> The "sound-dai" property has cells therefore phandle-array should be
> used, even if it is just one phandle.  This fixes dtbs_check warnings
> like:

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Krzysztof Kozlowski]

On Tue, Sep 01, 2020 at 12:03:49PM +0100, Mark Brown wrote:
> On Sun, Aug 30, 2020 at 01:26:32PM +0200, Krzysztof Kozlowski wrote:
> > The "sound-dai" property has cells therefore phandle-array should be
> > used, even if it is just one phandle.  This fixes dtbs_check warnings
> > like:
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

The usual prefix for bindings is "dt-bindings: ..." so I wonder what
type of prefix you expect:
1. ASoC: dt-bindings: ...
2. dt-bindings: ASoC: ...

Which one of these?

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

On Wed, Sep 02, 2020 at 11:10:38AM +0200, Krzysztof Kozlowski wrote:
> On Tue, Sep 01, 2020 at 12:03:49PM +0100, Mark Brown wrote:

> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.

> The usual prefix for bindings is "dt-bindings: ..." so I wonder what
> type of prefix you expect:
> 1. ASoC: dt-bindings: ...

This.  Bindings aren't a separate subsystem.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Krzysztof Kozlowski]

On Wed, Sep 02, 2020 at 10:38:39AM +0100, Mark Brown wrote:
> On Wed, Sep 02, 2020 at 11:10:38AM +0200, Krzysztof Kozlowski wrote:
> > On Tue, Sep 01, 2020 at 12:03:49PM +0100, Mark Brown wrote:
> 
> > > Please submit patches using subject lines reflecting the style for the
> > > subsystem, this makes it easier for people to identify relevant patches.
> 
> > The usual prefix for bindings is "dt-bindings: ..." so I wonder what
> > type of prefix you expect:
> > 1. ASoC: dt-bindings: ...
> 
> This.  Bindings aren't a separate subsystem.

Sure, thanks!

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Mark Brown]

On Sun, 30 Aug 2020 13:26:32 +0200, Krzysztof Kozlowski wrote:
> The "sound-dai" property has cells therefore phandle-array should be
> used, even if it is just one phandle.  This fixes dtbs_check warnings
> like:
> 
>   arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0
>   arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: midas-audio: Correct parsing sound-dai phandles
      commit: 3e7ba1c0432ef9a792b9c77d36f78037626303b0
[2/2] ASoC: odroid: Use unevaluatedProperties
      commit: a57307ca6b661e16f9435a25f376ac277c3de697

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Rob Herring]

On Tue, Sep 01, 2020 at 03:50:05PM +0100, Mark Brown wrote:
> On Sun, 30 Aug 2020 13:26:32 +0200, Krzysztof Kozlowski wrote:
> > The "sound-dai" property has cells therefore phandle-array should be
> > used, even if it is just one phandle.  This fixes dtbs_check warnings
> > like:
> > 
> >   arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0
> >   arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/2] ASoC: midas-audio: Correct parsing sound-dai phandles
>       commit: 3e7ba1c0432ef9a792b9c77d36f78037626303b0
> [2/2] ASoC: odroid: Use unevaluatedProperties
>       commit: a57307ca6b661e16f9435a25f376ac277c3de697

This one should be reverted/dropped too. Patch 1 is fine.

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

On Thu, Sep 03, 2020 at 10:47:38AM -0600, Rob Herring wrote:

> > [2/2] ASoC: odroid: Use unevaluatedProperties
> >       commit: a57307ca6b661e16f9435a25f376ac277c3de697

> This one should be reverted/dropped too. Patch 1 is fine.

There are others?  What's the issue with them?  It'd be easiest if you
could send patches doing whatever reverts you're looking for.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Rob Herring]

On Thu, Sep 3, 2020 at 11:27 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Sep 03, 2020 at 10:47:38AM -0600, Rob Herring wrote:
>
> > > [2/2] ASoC: odroid: Use unevaluatedProperties
> > >       commit: a57307ca6b661e16f9435a25f376ac277c3de697
>
> > This one should be reverted/dropped too. Patch 1 is fine.
>
> There are others?  What's the issue with them?  It'd be easiest if you
> could send patches doing whatever reverts you're looking for.

Just 1 other you picked up. See "ASoC: samsung-i2s: Use
unevaluatedProperties". Patches adding the missing properties (and
restoring 'additionalProperties' on these 2 if not reverted) is the
correct change.

I've gone thru and NAKed all of the others so more don't get picked up.


Rob

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Krzysztof Kozlowski]

On Thu, 3 Sep 2020 at 19:49, Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Sep 3, 2020 at 11:27 AM Mark Brown <broonie@kernel.org> wrote:
> >
> > On Thu, Sep 03, 2020 at 10:47:38AM -0600, Rob Herring wrote:
> >
> > > > [2/2] ASoC: odroid: Use unevaluatedProperties
> > > >       commit: a57307ca6b661e16f9435a25f376ac277c3de697
> >
> > > This one should be reverted/dropped too. Patch 1 is fine.
> >
> > There are others?  What's the issue with them?  It'd be easiest if you
> > could send patches doing whatever reverts you're looking for.
>
> Just 1 other you picked up. See "ASoC: samsung-i2s: Use
> unevaluatedProperties". Patches adding the missing properties (and
> restoring 'additionalProperties' on these 2 if not reverted) is the
> correct change.
>
> I've gone thru and NAKed all of the others so more don't get picked up.

Ah, my bad... Mark, I can send a follow up which restores the
additionalProperties (so kind of revert of the second patch) and fixes
the warning. Other way is that you just drop it and I will send a
correct fix later.

Sorry for the mess.

Best regards,
Krzysztpf

Re: [PATCH 1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

On Thu, Sep 03, 2020 at 08:08:51PM +0200, Krzysztof Kozlowski wrote:
> On Thu, 3 Sep 2020 at 19:49, Rob Herring <robh@kernel.org> wrote:

> > Just 1 other you picked up. See "ASoC: samsung-i2s: Use
> > unevaluatedProperties". Patches adding the missing properties (and
> > restoring 'additionalProperties' on these 2 if not reverted) is the
> > correct change.

> > I've gone thru and NAKed all of the others so more don't get picked up.

> Ah, my bad... Mark, I can send a follow up which restores the
> additionalProperties (so kind of revert of the second patch) and fixes
> the warning. Other way is that you just drop it and I will send a
> correct fix later.

Sure, that sounds great - I'm just finishing up for today anyway so I'll
look out for something tomorrow.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]