devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Kukjin Kim" <kgene@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
	"Jonathan Bakker" <xc-racer2@live.ca>,
	"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: [RFT 08/25] ARM: dts: s5pv210: remove dedicated 'audio-subsystem' node
Date: Mon,  7 Sep 2020 18:11:24 +0200	[thread overview]
Message-ID: <20200907161141.31034-9-krzk@kernel.org> (raw)
In-Reply-To: <20200907161141.31034-1-krzk@kernel.org>

The 'audio-subsystem' node is an artificial creation, not representing
real hardware.  The hardware is described by its nodes - AUDSS clock
controller and I2S0.

Remove the 'audio-subsystem' node along with its undocumented compatible
to fix dtbs_check warnings like:

  audio-subsystem: $nodename:0: 'audio-subsystem' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/boot/dts/s5pv210.dtsi | 65 +++++++++++++++-------------------
 1 file changed, 29 insertions(+), 36 deletions(-)

diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
index 46221a5c8ce5..2871351ab907 100644
--- a/arch/arm/boot/dts/s5pv210.dtsi
+++ b/arch/arm/boot/dts/s5pv210.dtsi
@@ -223,43 +223,36 @@
 			status = "disabled";
 		};
 
-		audio-subsystem {
-			compatible = "samsung,s5pv210-audss", "simple-bus";
-			#address-cells = <1>;
-			#size-cells = <1>;
-			ranges;
-
-			clk_audss: clock-controller@eee10000 {
-				compatible = "samsung,s5pv210-audss-clock";
-				reg = <0xeee10000 0x1000>;
-				clock-names = "hclk", "xxti",
-						"fout_epll",
-						"sclk_audio0";
-				clocks = <&clocks DOUT_HCLKP>, <&xxti>,
-						<&clocks FOUT_EPLL>,
-						<&clocks SCLK_AUDIO0>;
-				#clock-cells = <1>;
-			};
+		clk_audss: clock-controller@eee10000 {
+			compatible = "samsung,s5pv210-audss-clock";
+			reg = <0xeee10000 0x1000>;
+			clock-names = "hclk", "xxti",
+				      "fout_epll",
+				      "sclk_audio0";
+			clocks = <&clocks DOUT_HCLKP>, <&xxti>,
+				 <&clocks FOUT_EPLL>,
+				 <&clocks SCLK_AUDIO0>;
+			#clock-cells = <1>;
+		};
 
-			i2s0: i2s@eee30000 {
-				compatible = "samsung,s5pv210-i2s";
-				reg = <0xeee30000 0x1000>;
-				interrupt-parent = <&vic2>;
-				interrupts = <16>;
-				dma-names = "rx", "tx", "tx-sec";
-				dmas = <&pdma1 9>, <&pdma1 10>, <&pdma1 11>;
-				clock-names = "iis",
-						"i2s_opclk0",
-						"i2s_opclk1";
-				clocks = <&clk_audss CLK_I2S>,
-						<&clk_audss CLK_I2S>,
-						<&clk_audss CLK_DOUT_AUD_BUS>;
-				samsung,idma-addr = <0xc0010000>;
-				pinctrl-names = "default";
-				pinctrl-0 = <&i2s0_bus>;
-				#sound-dai-cells = <0>;
-				status = "disabled";
-			};
+		i2s0: i2s@eee30000 {
+			compatible = "samsung,s5pv210-i2s";
+			reg = <0xeee30000 0x1000>;
+			interrupt-parent = <&vic2>;
+			interrupts = <16>;
+			dma-names = "rx", "tx", "tx-sec";
+			dmas = <&pdma1 9>, <&pdma1 10>, <&pdma1 11>;
+			clock-names = "iis",
+				      "i2s_opclk0",
+				      "i2s_opclk1";
+			clocks = <&clk_audss CLK_I2S>,
+				 <&clk_audss CLK_I2S>,
+				 <&clk_audss CLK_DOUT_AUD_BUS>;
+			samsung,idma-addr = <0xc0010000>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2s0_bus>;
+			#sound-dai-cells = <0>;
+			status = "disabled";
 		};
 
 		i2s1: i2s@e2100000 {
-- 
2.17.1


  parent reply	other threads:[~2020-09-07 16:24 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 16:11 [PATCH 00/25] ARM: dts: s5pv210: Cleanup - dtschema warnings Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 01/25] dt-bindings: samsung: pmu: document S5Pv210 Krzysztof Kozlowski
2020-09-09 19:36   ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 02/25] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Krzysztof Kozlowski
2020-09-07 16:38   ` Jonathan Cameron
2020-09-07 17:11     ` Krzysztof Kozlowski
2020-09-08 20:24   ` Rob Herring
2020-09-08 20:25   ` Rob Herring
2020-09-10 11:55     ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Krzysztof Kozlowski
2020-09-07 16:39   ` Jonathan Cameron
2020-09-07 21:49   ` Jonathan Bakker
2020-09-08  6:48     ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 04/25] ARM: dts: s5pv210: fix pinctrl property of "vibrator-en" regulator in Aries Krzysztof Kozlowski
2020-09-09 19:39   ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 05/25] ARM: dts: s5pv210: remove DMA controller bus node name to fix dtschema warnings Krzysztof Kozlowski
2020-09-07 21:56   ` Jonathan Bakker
2020-09-07 16:11 ` [RFT 06/25] ARM: dts: s5pv210: move fixed clocks under root node Krzysztof Kozlowski
2020-09-07 21:59   ` Jonathan Bakker
2020-09-07 16:11 ` [RFT 07/25] ARM: dts: s5pv210: move PMU node out of clock controller Krzysztof Kozlowski
2020-09-07 22:02   ` Jonathan Bakker
2020-09-07 16:11 ` Krzysztof Kozlowski [this message]
2020-09-07 22:41   ` [RFT 08/25] ARM: dts: s5pv210: remove dedicated 'audio-subsystem' node Jonathan Bakker
2020-09-07 16:11 ` [RFT 09/25] ARM: dts: s5pv210: fix number of I2S DAI cells Krzysztof Kozlowski
2020-09-07 23:55   ` Jonathan Bakker
2020-09-08  6:53     ` Krzysztof Kozlowski
2020-09-08  8:38       ` Sylwester Nawrocki
2020-09-07 16:11 ` [PATCH 10/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aquilla Krzysztof Kozlowski
2020-09-09 19:43   ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 11/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aries family Krzysztof Kozlowski
2020-09-07 23:57   ` Jonathan Bakker
2020-09-08  6:54     ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 12/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Goni Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 13/25] ARM: dts: s5pv210: add RTC 32 KHz clock in SMDKC110 Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 14/25] ARM: dts: s5pv210: add RTC 32 KHz clock in SMDKV210 Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 15/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Torbreck Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 16/25] ARM: dts: s5pv210: use defines for GPIO flags in Aquila Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 17/25] ARM: dts: s5pv210: use defines for GPIO flags in Goni Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 18/25] ARM: dts: s5pv210: use defines for IRQ flags in SMDKV210 Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 19/25] ARM: dts: s5pv210: use defines for IRQ flags in Goni Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 20/25] ARM: dts: s5pv210: move fixed regulators under root node in Aquila Krzysztof Kozlowski
2020-09-16 17:16   ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 21/25] ARM: dts: s5pv210: move fixed regulators under root node in Goni Krzysztof Kozlowski
2020-09-16 17:16   ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 22/25] ARM: dts: s5pv210: replace deprecated "gpios" i2c-gpio property in Aquila Krzysztof Kozlowski
2020-09-16 17:17   ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 23/25] ARM: dts: s5pv210: replace deprecated "gpios" i2c-gpio property in Goni Krzysztof Kozlowski
2020-09-16 17:17   ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 24/25] ARM: dts: s5pv210: align SPI GPIO node name with dtschema in Aries Krzysztof Kozlowski
2020-09-07 23:34   ` Jonathan Bakker
2020-09-09 19:44   ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 25/25] ARM: dts: s5pv210: align DMA channels with dtschema Krzysztof Kozlowski
2020-09-08  0:17   ` Jonathan Bakker
     [not found]   ` <25178674-e4af-ba35-b7f0-42091208e0e8@live.ca>
2020-09-08  0:28     ` Jonathan Bakker
2020-09-08  6:57       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907161141.31034-9-krzk@kernel.org \
    --to=krzk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kgene@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=pawel.mikolaj.chmiel@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=xc-racer2@live.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).