From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org, richard@nod.at, vigneshr@ti.com,
arnd@arndb.de, brendanhiggins@google.com, tglx@linutronix.de,
boris.brezillon@collabora.com, anders.roxell@linaro.org,
masonccyang@mxic.com.tw, robh+dt@kernel.org,
linux-mips@vger.kernel.org, hauke.mehrtens@intel.com,
andriy.shevchenko@intel.com, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com
Subject: Re: [RESEND PATCH v12 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Mon, 7 Sep 2020 16:56:13 +0200 [thread overview]
Message-ID: <20200907165613.79f44c58@xps13> (raw)
In-Reply-To: <20200907152025.66c18f5e@xps13>
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Mon, 7 Sep 2020
15:20:25 +0200:
> Hi Murugan,
>
> A few more comments below, but I guess the driver looks better now.
>
> > +struct ebu_nand_controller {
> > + struct nand_controller controller;
> > + struct nand_chip chip;
> > + struct device *dev;
> > + void __iomem *ebu;
> > + void __iomem *hsnand;
> > + struct dma_chan *dma_tx;
> > + struct dma_chan *dma_rx;
> > + struct completion dma_access_complete;
> > + unsigned long clk_rate;
> > + struct clk *clk;
> > + u32 nd_para0;
> > + u8 cs_num;
> > + struct ebu_nand_cs cs[MAX_CS];
> > +};
> > +
> > +static inline struct ebu_nand_controller *nand_to_ebu(struct nand_chip *chip)
> > +{
> > + return container_of(chip, struct ebu_nand_controller, chip);
> > +}
> > +
> > +static u8 ebu_nand_readb(struct nand_chip *chip)
>
> Can't you prefix with intel_ instead of ebu_ ?
Actually not, as the IP is shared with MIPS IIUC, just ignore this
comment.
Thanks,
Miquèl
next prev parent reply other threads:[~2020-09-07 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 5:27 [RESEND PATCH v12 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-08-17 5:27 ` [RESEND PATCH v12 1/2] dt-bindings: mtd: Add Nand Flash Controller support for " Ramuthevar,Vadivel MuruganX
2020-08-17 5:27 ` [RESEND PATCH v12 2/2] mtd: rawnand: Add NAND controller support on " Ramuthevar,Vadivel MuruganX
2020-09-07 13:20 ` Miquel Raynal
2020-09-07 14:56 ` Miquel Raynal [this message]
2020-09-11 6:48 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907165613.79f44c58@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=anders.roxell@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@collabora.com \
--cc=brendanhiggins@google.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke.mehrtens@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=qi-ming.wu@intel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).