From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDC2C43461 for ; Mon, 7 Sep 2020 17:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6C8721789 for ; Mon, 7 Sep 2020 17:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599500835; bh=q8Itn2cHd3ckHrO+heD9TcNKbUw7qQ0g2d+sdj7DcEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=c/TeE3NyxNvY30XrrpWV6trd2m8dhVLl6IlF21GjfPT5y8ZJihbojMh1/h1+0Eyej dULJFxolKi0pdnAKDNCJjb/ZzC39nljmrChZWd+NAWwvIqTlxphdhjZA3Vdb8f6E2X Hjt0Nq99KV+qmhoELai1sUM3bCKkb7XVJl8LsFj4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729353AbgIGRrN (ORCPT ); Mon, 7 Sep 2020 13:47:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:52650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729396AbgIGRrJ (ORCPT ); Mon, 7 Sep 2020 13:47:09 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E90D5206E7; Mon, 7 Sep 2020 17:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599500828; bh=q8Itn2cHd3ckHrO+heD9TcNKbUw7qQ0g2d+sdj7DcEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oZbdYyHLOdO2oH+pjUHARSetGjw5yfzPVxe60BK2ZuHoCDEbbsxnpPJz5g0DEFUdf ISA5KcU14uYZBjNyZ0QOXX/PBJE2czgwveSjk42TV57MEjGHZWvVR0/ID4uNMaAOGQ yAUoIKO3mXE8d8HmCyit6ecbkupcZRzDlXVnM9pc= Received: by pali.im (Postfix) id 0819B814; Mon, 7 Sep 2020 19:47:05 +0200 (CEST) Date: Mon, 7 Sep 2020 19:47:05 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andre Heider Cc: Andrew Lunn , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Tomasz Maciej Nowak , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases Message-ID: <20200907174705.clknw4375smvt47o@pali> References: <20200907112718.5994-1-pali@kernel.org> <3ec54259-4bfe-8462-e8d5-083fc009707a@gmail.com> <20200907172303.GA3254313@lunn.ch> <20200907173534.aoupftjkxgcftfqo@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Monday 07 September 2020 19:43:08 Andre Heider wrote: > On 07/09/2020 19:35, Pali Rohár wrote: > > On Monday 07 September 2020 19:23:03 Andrew Lunn wrote: > > > > My dts-foo is a little rusty, but now that you labeled the ports in the > > > > .dtsi, can this whole "switch0" block reduced to something like: > > > > > > > > &switch0port1 { > > > > label = "lan1"; > > > > }; > > > > > > > > &switch0port3 { > > > > label = "wan"; > > > > }; > > > > > > Probably yes. > > > > > > But that is definitely too much for stable. > > > > Yes, this suggested change is not for stable, but looks like a nice > > cleanup. So it could be done in followup patch. > > > > Andre, are you going to prepare and test this followup change? > > I can prep the patch if you like, but the suggested cleanup only affects the > v7 dts files. I don't have that hardware version to test it, so could only > send an untested patch. As a result of this cleanup should be binary DTB file for V7 with same structure as DTB file without such cleanup patch, right? And this test (structure / content of compiled file) does not need particular hardware.