* [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix [not found] <20200907111027.21933-1-narmstrong@baylibre.com> @ 2020-09-07 11:10 ` Neil Armstrong 2020-09-07 11:10 ` [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings Neil Armstrong 1 sibling, 0 replies; 5+ messages in thread From: Neil Armstrong @ 2020-09-07 11:10 UTC (permalink / raw) To: thierry.reding, sam, devicetree Cc: dri-devel, linux-amlogic, linux-kernel, Neil Armstrong Shanghai Top Display Optolelectronics Co., Ltd is a display manufacturer from Shanghai. Web site of the company: http://www.shtdo.com/ Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index a1e4356cf522..4e9dfb352c68 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -1078,6 +1078,8 @@ patternProperties: description: TPK U.S.A. LLC "^tplink,.*": description: TP-LINK Technologies Co., Ltd. + "^tdo,.*": + description: Shangai Top Display Optoelectronics Co., Ltd "^tpo,.*": description: TPO "^tq,.*": -- 2.22.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings [not found] <20200907111027.21933-1-narmstrong@baylibre.com> 2020-09-07 11:10 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix Neil Armstrong @ 2020-09-07 11:10 ` Neil Armstrong 2020-09-07 11:45 ` Sam Ravnborg 1 sibling, 1 reply; 5+ messages in thread From: Neil Armstrong @ 2020-09-07 11:10 UTC (permalink / raw) To: thierry.reding, sam, devicetree Cc: dri-devel, linux-amlogic, linux-kernel, Neil Armstrong This add the bindings for the 1024*600 tl070wsh30 DSI panel. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- .../display/panel/tdo,tl070wsh30.yaml | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml diff --git a/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml new file mode 100644 index 000000000000..20f4fdedfcb0 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +# Copyright 2020 BayLibre, SAS +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/tdo,tl070wsh30.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TDO TL070WSH30 DSI panel + +maintainers: + - Neil Armstrong <narmstrong@baylibre.com> + +allOf: + - $ref: panel-common.yaml# + +properties: + + compatible: + enum: + - tdo,tl070wsh30 + + reg: + maxItems: 1 + description: DSI virtual channel + + backlight: true + reset-gpios: true + port: true + power-supply: true + +additionalProperties: false + +required: + - compatible + - power-supply + - reset-gpios + - port + - reg + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "tdo,tl070wsh30"; + reg = <0>; + power-supply = <&vcc_lcd_reg>; + backlight = <&panel_backlight>; + reset-gpios = <&gpio_reset>; + + port { + panel: endpoint { + remote-endpoint = <&mipi_dsi_out>; + }; + }; + }; + }; -- 2.22.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings 2020-09-07 11:10 ` [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings Neil Armstrong @ 2020-09-07 11:45 ` Sam Ravnborg 2020-09-07 13:24 ` Neil Armstrong 0 siblings, 1 reply; 5+ messages in thread From: Sam Ravnborg @ 2020-09-07 11:45 UTC (permalink / raw) To: Neil Armstrong Cc: thierry.reding, devicetree, dri-devel, linux-amlogic, linux-kernel Hi Neil. On Mon, Sep 07, 2020 at 01:10:26PM +0200, Neil Armstrong wrote: > This add the bindings for the 1024*600 tl070wsh30 DSI panel. The binding looks like a panel-simple-dsi.yaml candidate. Only differen is enable-gpios versus reset-gpios Could you check if we can use panel-simple-dsi-yaml. Sam > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > .../display/panel/tdo,tl070wsh30.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml > new file mode 100644 > index 000000000000..20f4fdedfcb0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +# Copyright 2020 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/tdo,tl070wsh30.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TDO TL070WSH30 DSI panel > + > +maintainers: > + - Neil Armstrong <narmstrong@baylibre.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + > + compatible: > + enum: > + - tdo,tl070wsh30 > + > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + backlight: true > + reset-gpios: true > + port: true > + power-supply: true > + > +additionalProperties: false > + > +required: > + - compatible > + - power-supply > + - reset-gpios > + - port > + - reg > + > +examples: > + - | > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "tdo,tl070wsh30"; > + reg = <0>; > + power-supply = <&vcc_lcd_reg>; > + backlight = <&panel_backlight>; > + reset-gpios = <&gpio_reset>; > + > + port { > + panel: endpoint { > + remote-endpoint = <&mipi_dsi_out>; > + }; > + }; > + }; > + }; > -- > 2.22.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings 2020-09-07 11:45 ` Sam Ravnborg @ 2020-09-07 13:24 ` Neil Armstrong 2020-09-07 19:24 ` Sam Ravnborg 0 siblings, 1 reply; 5+ messages in thread From: Neil Armstrong @ 2020-09-07 13:24 UTC (permalink / raw) To: Sam Ravnborg Cc: thierry.reding, devicetree, dri-devel, linux-amlogic, linux-kernel Hi, On 07/09/2020 13:45, Sam Ravnborg wrote: > Hi Neil. > > On Mon, Sep 07, 2020 at 01:10:26PM +0200, Neil Armstrong wrote: >> This add the bindings for the 1024*600 tl070wsh30 DSI panel. > > The binding looks like a panel-simple-dsi.yaml candidate. > Only differen is enable-gpios versus reset-gpios This is the only difference, the panel only has a reset signal and no enable signal. But I can add a reset-gpios to panel-simple-dsi.yaml, would it be ok ? Neil > > Could you check if we can use panel-simple-dsi-yaml. > > Sam > >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> .../display/panel/tdo,tl070wsh30.yaml | 58 +++++++++++++++++++ >> 1 file changed, 58 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml >> new file mode 100644 >> index 000000000000..20f4fdedfcb0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml >> @@ -0,0 +1,58 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +# Copyright 2020 BayLibre, SAS >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/panel/tdo,tl070wsh30.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: TDO TL070WSH30 DSI panel >> + >> +maintainers: >> + - Neil Armstrong <narmstrong@baylibre.com> >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + >> + compatible: >> + enum: >> + - tdo,tl070wsh30 >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + backlight: true >> + reset-gpios: true >> + port: true >> + power-supply: true >> + >> +additionalProperties: false >> + >> +required: >> + - compatible >> + - power-supply >> + - reset-gpios >> + - port >> + - reg >> + >> +examples: >> + - | >> + dsi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + panel@0 { >> + compatible = "tdo,tl070wsh30"; >> + reg = <0>; >> + power-supply = <&vcc_lcd_reg>; >> + backlight = <&panel_backlight>; >> + reset-gpios = <&gpio_reset>; >> + >> + port { >> + panel: endpoint { >> + remote-endpoint = <&mipi_dsi_out>; >> + }; >> + }; >> + }; >> + }; >> -- >> 2.22.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings 2020-09-07 13:24 ` Neil Armstrong @ 2020-09-07 19:24 ` Sam Ravnborg 0 siblings, 0 replies; 5+ messages in thread From: Sam Ravnborg @ 2020-09-07 19:24 UTC (permalink / raw) To: Neil Armstrong Cc: devicetree, thierry.reding, linux-kernel, dri-devel, linux-amlogic Hi Neil. On Mon, Sep 07, 2020 at 03:24:47PM +0200, Neil Armstrong wrote: > Hi, > > On 07/09/2020 13:45, Sam Ravnborg wrote: > > Hi Neil. > > > > On Mon, Sep 07, 2020 at 01:10:26PM +0200, Neil Armstrong wrote: > >> This add the bindings for the 1024*600 tl070wsh30 DSI panel. > > > > The binding looks like a panel-simple-dsi.yaml candidate. > > Only differen is enable-gpios versus reset-gpios > > This is the only difference, the panel only has a reset signal and no > enable signal. > > But I can add a reset-gpios to panel-simple-dsi.yaml, would it be ok ? Yes, that would be fine as long as it is not a required property. It was a mistake we did not add it from the beginning. There has been patches floating to add reset-gpios to panle.simple.c that I rejected - this was also wrong. Really simple and dumb panels has no reset but dsi panels that panel-simple supports too has a reset. Sam > > Neil > > > > > Could you check if we can use panel-simple-dsi-yaml. > > > > Sam > > > >> > >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > >> --- > >> .../display/panel/tdo,tl070wsh30.yaml | 58 +++++++++++++++++++ > >> 1 file changed, 58 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml > >> new file mode 100644 > >> index 000000000000..20f4fdedfcb0 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml > >> @@ -0,0 +1,58 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > >> +# Copyright 2020 BayLibre, SAS > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/display/panel/tdo,tl070wsh30.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: TDO TL070WSH30 DSI panel > >> + > >> +maintainers: > >> + - Neil Armstrong <narmstrong@baylibre.com> > >> + > >> +allOf: > >> + - $ref: panel-common.yaml# > >> + > >> +properties: > >> + > >> + compatible: > >> + enum: > >> + - tdo,tl070wsh30 > >> + > >> + reg: > >> + maxItems: 1 > >> + description: DSI virtual channel > >> + > >> + backlight: true > >> + reset-gpios: true > >> + port: true > >> + power-supply: true > >> + > >> +additionalProperties: false > >> + > >> +required: > >> + - compatible > >> + - power-supply > >> + - reset-gpios > >> + - port > >> + - reg > >> + > >> +examples: > >> + - | > >> + dsi { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + panel@0 { > >> + compatible = "tdo,tl070wsh30"; > >> + reg = <0>; > >> + power-supply = <&vcc_lcd_reg>; > >> + backlight = <&panel_backlight>; > >> + reset-gpios = <&gpio_reset>; > >> + > >> + port { > >> + panel: endpoint { > >> + remote-endpoint = <&mipi_dsi_out>; > >> + }; > >> + }; > >> + }; > >> + }; > >> -- > >> 2.22.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-07 19:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200907111027.21933-1-narmstrong@baylibre.com>
2020-09-07 11:10 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix Neil Armstrong
2020-09-07 11:10 ` [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings Neil Armstrong
2020-09-07 11:45 ` Sam Ravnborg
2020-09-07 13:24 ` Neil Armstrong
2020-09-07 19:24 ` Sam Ravnborg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).