From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A04C433E2 for ; Tue, 8 Sep 2020 06:55:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 523E521919 for ; Tue, 8 Sep 2020 06:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599548109; bh=DETA+0KrLFGYn+ConUVH+45tfhX9j4ZSY1Mr5Bili0s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fCpxD6sCx97jEKPbauasn4EK03uAzXe+qIDVtvt3qLmkR2hnfOT2GRMtTe4UwEY7X PsUIgVEatXKsrVkAazYq/a5ZiUVSzKsElv8HA1wL6LFliGR6YQFFGxuFv7ss9bipYc QJBW+1+r0jfkqrfFSOMGikPU9yaGQQsn2L1nH9Uw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728953AbgIHGzI (ORCPT ); Tue, 8 Sep 2020 02:55:08 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:43690 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728479AbgIHGzF (ORCPT ); Tue, 8 Sep 2020 02:55:05 -0400 Received: by mail-ej1-f66.google.com with SMTP id o8so7724897ejb.10; Mon, 07 Sep 2020 23:55:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z8F+J0dpPaiXwn0OwzuDM1BFUxGBJiTwV0EOyF8yDGs=; b=XVeM8rqWwz4lWbvONRX7NrXSwWogaWtzDZYoOEdikHQOBKYS2bHDFGshhlmHHR/1// kGalxlQfWRB5nrjZXEZ8PCwq6uuzlsKDEw0FhMNVRFTA9GRJUDZBuOEO5b5MqPmxEIrp I6qD17yECB229Dz98CV7zsqcy5F8j9Oo5l+atqXLAS4WG9FxbkGwVUpE58VVhU/Adr0B wJKfYZKkAbQu1RM7Kayi4tal0wt+2qO2gZKKvu7NDdgPxRskTBkbakgVLmPa8+sA4pU8 X0EQiFlsoSQlrFVFe1DyZ2ErzjrmAPHY1rYeavaf5IRPufkTEWUhuAObCTmKJAjdI+uw i1DQ== X-Gm-Message-State: AOAM533b/hqmuXUgJShWcz3A/wVf9lBYBTuY1TuIdFfHKbqES6tTPLHY dvmXNCfiyFiKF+Ak4ZekLEl57QNBCgI= X-Google-Smtp-Source: ABdhPJwqcrsoBbvXyOtx/zQlu89AL3rfhHav4wMeQ17ElFc0uWvFvkR65vNYNv3eRpa34TVxqpdFcA== X-Received: by 2002:a17:906:faec:: with SMTP id lu44mr23959522ejb.527.1599548102559; Mon, 07 Sep 2020 23:55:02 -0700 (PDT) Received: from pi3 ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id 16sm3865463edx.72.2020.09.07.23.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 23:55:01 -0700 (PDT) Date: Tue, 8 Sep 2020 08:54:59 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Cc: Kukjin Kim , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , =?utf-8?B?UGF3ZcWC?= Chmiel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 11/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aries family Message-ID: <20200908065459.GC24227@pi3> References: <20200907161141.31034-1-krzk@kernel.org> <20200907161141.31034-12-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Sep 07, 2020 at 04:57:53PM -0700, Jonathan Bakker wrote: > Hi Krzysztof, > > On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > > The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. > > However there is no such clock provider but rather a regulator driver > > which registers the clock as a regulator. This is an old driver which > > will not be updated so add a workaround - a fixed-clock to fill missing > > clock phandle reference in S3C RTC. > > > > This fixes dtbs_check warnings: > > > > rtc@e2800000: clocks: [[2, 145]] is too short > > rtc@e2800000: clock-names: ['rtc'] is too short > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/boot/dts/s5pv210-aries.dtsi | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi > > index 6ba23562da46..86c3b26fd21e 100644 > > --- a/arch/arm/boot/dts/s5pv210-aries.dtsi > > +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi > > @@ -47,6 +47,13 @@ > > }; > > }; > > > > + pmic_ap_clk: clock-0 { > > + /* Workaround for missing clock on PMIC */ > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <32768>; > > + }; > > + > > bt_codec: bt_sco { > > compatible = "linux,bt-sco"; > > #sound-dai-cells = <0>; > > @@ -825,6 +832,11 @@ > > samsung,pwm-outputs = <1>; > > }; > > > > +&rtc { > > + clocks = <&clocks CLK_RTC>, <&pmic_ap_clk>; > > + clock-names = "rtc", "rtc_src"; > > Missing a > > status = "okay"; > > here, but with that it works fine for me. Looks like it's also > missing in the patches for the other devices as well. It wasn't there on purpose - I did not want to enable the RTC, just fix the DTS with the dtschema. However a separate patch could be to actually enable it. I'll add your tested-by to this patch. Best regards, Krzysztof