From: Rob Herring <robh@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: kishon@ti.com, repk@triplefau.lt, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute
Date: Tue, 8 Sep 2020 13:50:03 -0600 [thread overview]
Message-ID: <20200908195003.GB790974@bogus> (raw)
In-Reply-To: <20200907073402.26674-2-narmstrong@baylibre.com>
On Mon, Sep 07, 2020 at 09:34:00AM +0200, Neil Armstrong wrote:
> The Amlogic AXG MIPI + PCIe Analog PHY should be a subnode of the hhi mfd
> node like the axg-clkc node.
>
> Thus the reg attribute is not needed.
If the phy registers have an address then it should remain even if Linux
happens to not care. The exception is if the registers are all
interleaved with other stuff.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> index 18c1ec5e19ad..a9040aa387cf 100644
> --- a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> @@ -13,15 +13,11 @@ properties:
> compatible:
> const: amlogic,axg-mipi-pcie-analog-phy
>
> - reg:
> - maxItems: 1
> -
> "#phy-cells":
> const: 1
>
> required:
> - compatible
> - - reg
> - "#phy-cells"
>
> additionalProperties: false
> --
> 2.22.0
>
next prev parent reply other threads:[~2020-09-08 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200907073402.26674-1-narmstrong@baylibre.com>
2020-09-07 7:34 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute Neil Armstrong
2020-09-08 19:48 ` [PATCH 1/3] dt-bindings: phy: amlogic, meson-axg-mipi-pcie-analog: " Rob Herring
2020-09-08 19:50 ` Rob Herring [this message]
2020-09-09 7:31 ` [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: " Neil Armstrong
2020-09-07 7:34 ` [PATCH 2/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove phy cell parameter Neil Armstrong
2020-09-15 15:29 ` [PATCH 2/3] dt-bindings: phy: amlogic, meson-axg-mipi-pcie-analog: " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908195003.GB790974@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=repk@triplefau.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).