From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D453BC43461 for ; Wed, 9 Sep 2020 06:29:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AB0720936 for ; Wed, 9 Sep 2020 06:29:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AsUm+/dS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726036AbgIIG3v (ORCPT ); Wed, 9 Sep 2020 02:29:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbgIIG3t (ORCPT ); Wed, 9 Sep 2020 02:29:49 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE585C061573 for ; Tue, 8 Sep 2020 23:29:48 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id k18so1123792wmj.5 for ; Tue, 08 Sep 2020 23:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=kTpw1wGO0FeGTusMwEJcgWxaFgxhMz0VC4CueeQTfjk=; b=AsUm+/dSzTrufZhXxmra4vzPb2Ak1BIZ4acU5842n2b4hDwuAgeBgKCrC1BM6gabru FEW+lPCjeUUkaZIrJSo1uKg9vawUQm5saMTXE0rVgOtG0gwlj9m3EYP9t1fEACPjXlgW CHFaQnLEUcb9jehh4KeKoKUOcefeJ4CNCPdBKMA4nTyauRN5DkBr/+ockXcvYNPgtdZZ V1vlLYWeZLkYdCF0M3vY6CWy0/7jJmzLNbBr/T8e4W1YpDgdGuMWg0s/qcS4ob5FJ8VB 1Xvu0/dPw+HU89pLgZYTcrIQ+2dchSqq9BmxjyfP8X5pKKFuTh52b0PFABALDjOHEIgF 4+lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=kTpw1wGO0FeGTusMwEJcgWxaFgxhMz0VC4CueeQTfjk=; b=Np4auiYdNPOKpd8v9yqtQNB0ETxGBYt1xKLLPBTrssyPGDur3HbIy24hY6WnTUBTc5 80WQnOaIrVrK71gls/kHc2y6PlAtslD93JXypr3DyPr3GoDuZZ6Y2KyxF3/7yqJ0lpLy Jkjc3Nk3X+ckd1tgiLwclHCI4i+4rOp6dRmfVLacZ/N7hAEmYdDe+QjBx7lME+QK43iL 1XmWU3Ce3c8UGw4xj0KsCRBGByLHDlvo5ohmY6QaJUrIa9ZItNURiJ3t39loy6vu7tZT p/IA+DQMpJzbhH28vWVCTpYSvoKS6X/9AKRlis8j/o4wN7NtTUOFRFlSAuX4/L/scl0s jz6w== X-Gm-Message-State: AOAM532embxHOJyrEoNg/ipAik446bGvlMAjJ/kouS3RBIBae/9foWay CRiKpEUXMhG75TClB8U0aQJE7w== X-Google-Smtp-Source: ABdhPJxLhLAkdeSgZh2QIb6smIB1NhPOqFxd67AifJ8AzzH55lf7vSa91vXGOHqmkS1J9dbPHj+cmQ== X-Received: by 2002:a1c:7918:: with SMTP id l24mr2019308wme.46.1599632987325; Tue, 08 Sep 2020 23:29:47 -0700 (PDT) Received: from dell ([91.110.221.179]) by smtp.gmail.com with ESMTPSA id v9sm2758984wrv.35.2020.09.08.23.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 23:29:46 -0700 (PDT) Date: Wed, 9 Sep 2020 07:29:45 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Rob Herring , Tim Harvey , Robert Jones , Matti Vaittinen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-power@fi.rohmeurope.com Subject: Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples Message-ID: <20200909062945.GY4400@dell> References: <20200908145900.4423-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200908145900.4423-1-krzk@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 08 Sep 2020, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags, assuming the author of the code wanted some > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/mfd/act8945a.txt | 2 +- > Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml | 3 ++- > Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) Looks good, but I'd like the author to review. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog