From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Dan Murphy <dmurphy@ti.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
newbytee@protonmail.com, Stephan Gerhold <stephan@gerhold.net>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: leds: Add DT binding for Richtek RT8515
Date: Wed, 9 Sep 2020 10:37:35 +0200 [thread overview]
Message-ID: <20200909083735.GA10891@amd> (raw)
In-Reply-To: <e4ac5ea8-916d-1270-c9ae-64870b2f7c8d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
Hi!
> >>>+ led {
> >>>+ function = LED_FUNCTION_FLASH;
> >>>+ color = <LED_COLOR_ID_WHITE>;
> >>>+ flash-max-timeout-us = <250000>;
> >>
> >>Constraints for this property are needed above.
> >
> >Can you elaborate on what you expect this to look like?
> >The property is from common.yaml, so should that be
> >extended with a constraint?
>
> Constraints are specific to the hardware, so those should
> be provided in the related bindings.
> Generally it is customary in similar cases to give min, max
> and step values.
This looks okay to me.
Driver already knows what the step is, so there's no need to specify
it in the device tree. I was always wondering why minimum is useful. I
guess most hardware can just use first step as a minimum, again no
need to specify that.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2020-09-09 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 9:07 [PATCH 1/2] dt-bindings: leds: Add DT binding for Richtek RT8515 Linus Walleij
2020-08-13 21:06 ` Jacek Anaszewski
2020-08-19 21:05 ` Linus Walleij
2020-08-19 21:20 ` Jacek Anaszewski
2020-09-09 8:37 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909083735.GA10891@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=newbytee@protonmail.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).