From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84BC0C433E2 for ; Wed, 9 Sep 2020 08:37:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 443A621D7B for ; Wed, 9 Sep 2020 08:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728197AbgIIIhj (ORCPT ); Wed, 9 Sep 2020 04:37:39 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:47960 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbgIIIhj (ORCPT ); Wed, 9 Sep 2020 04:37:39 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 482B01C0B87; Wed, 9 Sep 2020 10:37:36 +0200 (CEST) Date: Wed, 9 Sep 2020 10:37:35 +0200 From: Pavel Machek To: Jacek Anaszewski Cc: Linus Walleij , Dan Murphy , Linux LED Subsystem , newbytee@protonmail.com, Stephan Gerhold , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH 1/2] dt-bindings: leds: Add DT binding for Richtek RT8515 Message-ID: <20200909083735.GA10891@amd> References: <20200812090711.2644688-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UugvWAfsgieZRqgk" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --UugvWAfsgieZRqgk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>>+ led { > >>>+ function =3D LED_FUNCTION_FLASH; > >>>+ color =3D ; > >>>+ flash-max-timeout-us =3D <250000>; > >> > >>Constraints for this property are needed above. > > > >Can you elaborate on what you expect this to look like? > >The property is from common.yaml, so should that be > >extended with a constraint? >=20 > Constraints are specific to the hardware, so those should > be provided in the related bindings. > Generally it is customary in similar cases to give min, max > and step values. This looks okay to me. Driver already knows what the step is, so there's no need to specify it in the device tree. I was always wondering why minimum is useful. I guess most hardware can just use first step as a minimum, again no need to specify that. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --UugvWAfsgieZRqgk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl9YlE8ACgkQMOfwapXb+vLshACfeTnYPFKn8obOuFJOgCVnpULJ I2gAnjEoUf6/ABw6SWFFt9C/FFZypw47 =gvo+ -----END PGP SIGNATURE----- --UugvWAfsgieZRqgk--