From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E7D6C43461 for ; Wed, 9 Sep 2020 08:44:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D426E215A4 for ; Wed, 9 Sep 2020 08:44:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728207AbgIIIoP (ORCPT ); Wed, 9 Sep 2020 04:44:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728197AbgIIIoN (ORCPT ); Wed, 9 Sep 2020 04:44:13 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CC28C061755 for ; Wed, 9 Sep 2020 01:44:12 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFvhq-0007Uz-VG; Wed, 09 Sep 2020 10:43:54 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1kFvhl-0000xY-8I; Wed, 09 Sep 2020 10:43:49 +0200 Date: Wed, 9 Sep 2020 10:43:49 +0200 From: Marco Felsch To: Florian Fainelli Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, zhengdejin5@gmail.com, richard.leitner@skidata.com, netdev@vger.kernel.org, kernel@pengutronix.de, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/5] net: phy: smsc: skip ENERGYON interrupt if disabled Message-ID: <20200909084349.mst4xbayjsukt7dy@pengutronix.de> References: <20200908112520.3439-1-m.felsch@pengutronix.de> <20200908112520.3439-2-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:42:52 up 299 days, 1 min, 303 users, load average: 0.01, 0.08, 0.08 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20-09-08 18:58, Florian Fainelli wrote: > > > On 9/8/2020 4:25 AM, Marco Felsch wrote: > > Don't enable the interrupt if the platform disable the energy detection > > by "smsc,disable-energy-detect". > > > > Signed-off-by: Marco Felsch > > Reviewed-by: Andrew Lunn > > --- > > v2: > > - Add Andrew's tag > > > > drivers/net/phy/smsc.c | 15 +++++++++++---- > > 1 file changed, 11 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c > > index 74568ae16125..fa539a867de6 100644 > > --- a/drivers/net/phy/smsc.c > > +++ b/drivers/net/phy/smsc.c > > @@ -37,10 +37,17 @@ struct smsc_phy_priv { > > static int smsc_phy_config_intr(struct phy_device *phydev) > > { > > - int rc = phy_write (phydev, MII_LAN83C185_IM, > > - ((PHY_INTERRUPT_ENABLED == phydev->interrupts) > > - ? MII_LAN83C185_ISF_INT_PHYLIB_EVENTS > > - : 0)); > > + struct smsc_phy_priv *priv = phydev->priv; > > + u16 intmask = 0; > > + int rc; > > + > > + if (phydev->interrupts) { > > Not that it changes the code functionally, but it would be nice to preserve > the phydev->interrupts == PHY_INTERRUPT_ENABLED. Okay, I will apply this and add your reviewed-by tag. Thanks, Marco > > > + intmask = MII_LAN83C185_ISF_INT4 | MII_LAN83C185_ISF_INT6; > > + if (priv->energy_enable) > > + intmask |= MII_LAN83C185_ISF_INT7; > > + } > > Reviewed-by: Florian Fainelli > -- > Florian > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |