* [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype @ 2020-09-10 5:46 Hsin-Yi Wang 2020-09-10 5:46 ` [PATCH 2/2] arm64: dts: mt8183: kukui: " Hsin-Yi Wang 2020-09-10 7:20 ` [PATCH 1/2] arm64: dts: mt8173: elm: " Enric Balletbo i Serra 0 siblings, 2 replies; 6+ messages in thread From: Hsin-Yi Wang @ 2020-09-10 5:46 UTC (permalink / raw) To: linux-mediatek Cc: Rob Herring, Matthias Brugger, devicetree, linux-arm-kernel, linux-kernel, Enric Balletbo i Serra Set uart0 iotype to mmio32 to make earlycon work with stdout-path. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index a5a12b2599a4a..d54e62f72c65d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -1160,6 +1160,8 @@ &thermal { }; &uart0 { + reg-io-width = <4>; + reg-shift = <2>; status = "okay"; }; -- 2.28.0.526.ge36021eeef-goog ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: mt8183: kukui: Set uart0 to mmio32 iotype 2020-09-10 5:46 [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype Hsin-Yi Wang @ 2020-09-10 5:46 ` Hsin-Yi Wang 2020-09-10 7:20 ` [PATCH 1/2] arm64: dts: mt8173: elm: " Enric Balletbo i Serra 1 sibling, 0 replies; 6+ messages in thread From: Hsin-Yi Wang @ 2020-09-10 5:46 UTC (permalink / raw) To: linux-mediatek Cc: Rob Herring, Matthias Brugger, devicetree, linux-arm-kernel, linux-kernel, Enric Balletbo i Serra Set uart0 iotype to mmio32 to make earlycon work with stdout-path. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index f0a070535b340..f6991bdaac1c6 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -750,6 +750,8 @@ &u3phy { &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins_default>; + reg-io-width = <4>; + reg-shift = <2>; status = "okay"; }; -- 2.28.0.526.ge36021eeef-goog ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype 2020-09-10 5:46 [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype Hsin-Yi Wang 2020-09-10 5:46 ` [PATCH 2/2] arm64: dts: mt8183: kukui: " Hsin-Yi Wang @ 2020-09-10 7:20 ` Enric Balletbo i Serra 2020-09-10 7:57 ` Hsin-Yi Wang 1 sibling, 1 reply; 6+ messages in thread From: Enric Balletbo i Serra @ 2020-09-10 7:20 UTC (permalink / raw) To: Hsin-Yi Wang, linux-mediatek Cc: Rob Herring, Matthias Brugger, devicetree, linux-arm-kernel, linux-kernel Hi Hsin-Yi, On 10/9/20 7:46, Hsin-Yi Wang wrote: > Set uart0 iotype to mmio32 to make earlycon work with stdout-path. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index a5a12b2599a4a..d54e62f72c65d 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -1160,6 +1160,8 @@ &thermal { > }; > > &uart0 { > + reg-io-width = <4>; > + reg-shift = <2>; I am wondering if these properties are common enough to go to mt8173.dtsi instead of here. > status = "okay"; > }; > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype 2020-09-10 7:20 ` [PATCH 1/2] arm64: dts: mt8173: elm: " Enric Balletbo i Serra @ 2020-09-10 7:57 ` Hsin-Yi Wang 2020-09-10 8:16 ` Enric Balletbo i Serra 0 siblings, 1 reply; 6+ messages in thread From: Hsin-Yi Wang @ 2020-09-10 7:57 UTC (permalink / raw) To: Enric Balletbo i Serra Cc: moderated list:ARM/Mediatek SoC support, Rob Herring, Matthias Brugger, Devicetree List, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, lkml On Thu, Sep 10, 2020 at 3:20 PM Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > Hi Hsin-Yi, > > On 10/9/20 7:46, Hsin-Yi Wang wrote: > > Set uart0 iotype to mmio32 to make earlycon work with stdout-path. > > > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > > --- > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > index a5a12b2599a4a..d54e62f72c65d 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > @@ -1160,6 +1160,8 @@ &thermal { > > }; > > > > &uart0 { > > + reg-io-width = <4>; > > + reg-shift = <2>; > > I am wondering if these properties are common enough to go to mt8173.dtsi > instead of here. > Since stdout-path is set on elm.dtsi (using uart0), so I add this attribute here. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype 2020-09-10 7:57 ` Hsin-Yi Wang @ 2020-09-10 8:16 ` Enric Balletbo i Serra 2020-09-10 8:44 ` Hsin-Yi Wang 0 siblings, 1 reply; 6+ messages in thread From: Enric Balletbo i Serra @ 2020-09-10 8:16 UTC (permalink / raw) To: Hsin-Yi Wang Cc: moderated list:ARM/Mediatek SoC support, Rob Herring, Matthias Brugger, Devicetree List, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, lkml Hi Hsin-Yi, On 10/9/20 9:57, Hsin-Yi Wang wrote: > On Thu, Sep 10, 2020 at 3:20 PM Enric Balletbo i Serra > <enric.balletbo@collabora.com> wrote: >> >> Hi Hsin-Yi, >> >> On 10/9/20 7:46, Hsin-Yi Wang wrote: >>> Set uart0 iotype to mmio32 to make earlycon work with stdout-path. >>> >>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> >>> --- >>> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi >>> index a5a12b2599a4a..d54e62f72c65d 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi >>> @@ -1160,6 +1160,8 @@ &thermal { >>> }; >>> >>> &uart0 { >>> + reg-io-width = <4>; >>> + reg-shift = <2>; >> >> I am wondering if these properties are common enough to go to mt8173.dtsi >> instead of here. >> > Since stdout-path is set on elm.dtsi (using uart0), so I add this > attribute here. > Why needs to be defined in the same place that stdout-path is set? My guess is that reg-io-width and reg-shift are SoC specific, as they define how the IO access to the register is done. In fact, I think that these properties should be added in all the uarts, not only the one that has defined the stdout-path. Cheers, Enric ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype 2020-09-10 8:16 ` Enric Balletbo i Serra @ 2020-09-10 8:44 ` Hsin-Yi Wang 0 siblings, 0 replies; 6+ messages in thread From: Hsin-Yi Wang @ 2020-09-10 8:44 UTC (permalink / raw) To: Enric Balletbo i Serra Cc: moderated list:ARM/Mediatek SoC support, Rob Herring, Matthias Brugger, Devicetree List, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, lkml On Thu, Sep 10, 2020 at 4:16 PM Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > Hi Hsin-Yi, > > On 10/9/20 9:57, Hsin-Yi Wang wrote: > > On Thu, Sep 10, 2020 at 3:20 PM Enric Balletbo i Serra > > <enric.balletbo@collabora.com> wrote: > >> > >> Hi Hsin-Yi, > >> > >> On 10/9/20 7:46, Hsin-Yi Wang wrote: > >>> Set uart0 iotype to mmio32 to make earlycon work with stdout-path. > >>> > >>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > >>> --- > >>> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > >>> index a5a12b2599a4a..d54e62f72c65d 100644 > >>> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > >>> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > >>> @@ -1160,6 +1160,8 @@ &thermal { > >>> }; > >>> > >>> &uart0 { > >>> + reg-io-width = <4>; > >>> + reg-shift = <2>; > >> > >> I am wondering if these properties are common enough to go to mt8173.dtsi > >> instead of here. > >> > > Since stdout-path is set on elm.dtsi (using uart0), so I add this > > attribute here. > > > > Why needs to be defined in the same place that stdout-path is set? > > My guess is that reg-io-width and reg-shift are SoC specific, as they define how > the IO access to the register is done. In fact, I think that these properties > should be added in all the uarts, not only the one that has defined the stdout-path. > Okay, I'll apply them to all uart. Thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-10 8:46 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-09-10 5:46 [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype Hsin-Yi Wang 2020-09-10 5:46 ` [PATCH 2/2] arm64: dts: mt8183: kukui: " Hsin-Yi Wang 2020-09-10 7:20 ` [PATCH 1/2] arm64: dts: mt8173: elm: " Enric Balletbo i Serra 2020-09-10 7:57 ` Hsin-Yi Wang 2020-09-10 8:16 ` Enric Balletbo i Serra 2020-09-10 8:44 ` Hsin-Yi Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).