From: Krzysztof Kozlowski <krzk@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-nfc@lists.01.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v3 2/8] dt-bindings: net: nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs
Date: Thu, 10 Sep 2020 18:12:13 +0200 [thread overview]
Message-ID: <20200910161219.6237-3-krzk@kernel.org> (raw)
In-Reply-To: <20200910161219.6237-1-krzk@kernel.org>
The device tree property prefix describes the vendor, which in case of
S3FWRN5 chip is Samsung. Therefore the "s3fwrn5" prefix for "en-gpios"
and "fw-gpios" is not correct and should be deprecated. Introduce
properly named properties for these GPIOs and rename the fw-gpios" to
"wake-gpios" to better describe its purpose.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
.../bindings/net/nfc/samsung,s3fwrn5.yaml | 24 ++++++++++++++-----
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
index f43d31a2d94b..cb0b8a560282 100644
--- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
+++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
@@ -14,30 +14,42 @@ properties:
compatible:
const: samsung,s3fwrn5-i2c
+ en-gpios:
+ maxItems: 1
+ description:
+ Output GPIO pin used for enabling/disabling the chip
+
interrupts:
maxItems: 1
reg:
maxItems: 1
+ wake-gpios:
+ maxItems: 1
+ description:
+ Output GPIO pin used to enter firmware mode and sleep/wakeup control
+
s3fwrn5,en-gpios:
maxItems: 1
+ deprecated: true
description:
- Output GPIO pin used for enabling/disabling the chip
+ Use en-gpios
s3fwrn5,fw-gpios:
maxItems: 1
+ deprecated: true
description:
- Output GPIO pin used to enter firmware mode and sleep/wakeup control
+ Use wake-gpios
additionalProperties: false
required:
- compatible
+ - en-gpios
- interrupts
- reg
- - s3fwrn5,en-gpios
- - s3fwrn5,fw-gpios
+ - wake-gpios
examples:
- |
@@ -55,7 +67,7 @@ examples:
interrupt-parent = <&gpa1>;
interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
- s3fwrn5,en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
- s3fwrn5,fw-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
+ en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
+ wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
};
};
--
2.17.1
next prev parent reply other threads:[~2020-09-10 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 16:12 [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 1/8] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Krzysztof Kozlowski
2020-09-10 16:12 ` Krzysztof Kozlowski [this message]
2020-09-10 16:12 ` [PATCH v3 3/8] nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 4/8] nfc: s3fwrn5: Remove unneeded 'ret' variable Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 5/8] nfc: s3fwrn5: Add missing CRYPTO_HASH dependency Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 6/8] nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 7/8] MAINTAINERS: Add Krzysztof Kozlowski to Samsung S3FWRN5 and remove Robert Krzysztof Kozlowski
2020-09-10 16:12 ` [PATCH v3 8/8] arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433 TM2 Krzysztof Kozlowski
2020-09-10 22:22 ` [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups David Miller
2020-09-11 6:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910161219.6237-3-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=k.opasiak@samsung.com \
--cc=kgene@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).