From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Gene Chen <gene.chen.richtek@gmail.com>,
robh+dt@kernel.org, matthias.bgg@gmail.com, dmurphy@ti.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
gene_chen@richtek.com, Wilma.Wu@mediatek.com,
shufan_lee@richtek.com, cy_huang@richtek.com,
benjamin.chao@mediatek.com
Subject: Re: [PATCH v3 1/2] leds: mt6360: Add LED driver for MT6360
Date: Fri, 11 Sep 2020 09:05:03 +0200 [thread overview]
Message-ID: <20200911070503.GA9818@amd> (raw)
In-Reply-To: <559a568e-3a2e-33c6-43aa-547a18f8e26b@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
Hi!
> >+{
> >+ struct mt6360_led *led = container_of(lcdev, struct mt6360_led, flash.led_cdev);
> >+ struct mt6360_priv *priv = led->priv;
> >+ u32 enable_mask = MT6360_TORCHEN_MASK | MT6360_FLCSEN_MASK(led->led_no);
> >+ u32 val = (level) ? MT6360_FLCSEN_MASK(led->led_no) : 0;
> >+ u32 prev = priv->fled_torch_used, curr;
> >+ int ret;
> >+
> >+ dev_dbg(lcdev->dev, "[%d] brightness %d\n", led->led_no, level);
> >+ if (priv->fled_strobe_used) {
> >+ dev_warn(lcdev->dev, "Please disable strobe first [%d]\n", priv->fled_strobe_used);
>
> Doesn't hardware handle that? IOW, what happens when you have enabled
> both torch and flash? If flash just overrides torch mode, than you
> should not prevent enabling torch in this case.
Yep, this is strange/confusing... and was reason why I asked for not
supporting strobe from sysfs.
Could I get you to remove code you are not commenting at when
reviewing?
> >+MODULE_AUTHOR("Gene Chen <gene_chen@richtek.com>");
> >+MODULE_DESCRIPTION("MT6360 Led Driver");
Led -> LED.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-09-11 7:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 10:27 [PATCH v3 0/2] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-09-07 10:27 ` [PATCH v3 1/2] " Gene Chen
2020-09-08 14:13 ` Dan Murphy
2020-09-08 22:25 ` Pavel Machek
2020-09-09 23:49 ` Gene Chen
2020-09-10 12:29 ` Pavel Machek
2020-09-10 20:23 ` Jacek Anaszewski
2020-09-10 20:25 ` Pavel Machek
2020-09-10 20:31 ` Jacek Anaszewski
2020-09-09 13:48 ` Andy Shevchenko
2020-09-10 0:11 ` Gene Chen
2020-09-10 8:18 ` Pavel Machek
2020-09-10 11:34 ` Andy Shevchenko
2020-09-10 12:28 ` Pavel Machek
2020-09-10 11:46 ` Andy Shevchenko
2020-09-10 21:42 ` Jacek Anaszewski
2020-09-11 7:05 ` Pavel Machek [this message]
2020-09-10 23:24 ` Gene Chen
2020-09-11 21:21 ` Jacek Anaszewski
2020-09-11 20:56 ` Jacek Anaszewski
2020-09-07 10:27 ` [PATCH v3 2/2] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-09-08 13:55 ` Dan Murphy
2020-09-08 22:22 ` Pavel Machek
2020-09-15 15:51 ` Rob Herring
2020-09-08 14:14 ` [PATCH v3 0/2] leds: mt6360: Add LED driver for MT6360 Dan Murphy
2020-09-09 0:00 ` Gene Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911070503.GA9818@amd \
--to=pavel@ucw.cz \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).