From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB92C433E2 for ; Sat, 12 Sep 2020 09:49:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55B6A2158C for ; Sat, 12 Sep 2020 09:49:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599904163; bh=oNheghBTMGf20w2jhhK9s/ksfsN7xnyd7oIDFq5CbBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rI44HaD964EwUiHhTdqFUmRaHcaJdET0CX+ENp0DoLlhk81SRYQwwcZYlNduC6+H6 PdeBgh62zKLlI22CrgRXTeCNMJ91dvXTLhf9hMEAaQuOx6aGr1HR1z7XLvIjfUAhRL GLx4FJPEGgO+JbO+dY1AIbll84l1m8sAPo9YZ0Tk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725817AbgILJtW (ORCPT ); Sat, 12 Sep 2020 05:49:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:34496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbgILJtV (ORCPT ); Sat, 12 Sep 2020 05:49:21 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A120214D8; Sat, 12 Sep 2020 09:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599904160; bh=oNheghBTMGf20w2jhhK9s/ksfsN7xnyd7oIDFq5CbBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QFLfSjoAuAjG/LccnLPi94ijxxhgGL4A9K6lBEHWAJGH3YtCknJykEXLonywG/SHP eGe9+KTYvAcqDEefc4DJa3JmUC8wGOu0amfrLzaB3ZVPcLZXyo/9Pe4k2wvmD6xuBG ZlKKbfZzIQSthP6DiiTUfxBKKv7XeQXVSOanWBpc= Date: Sat, 12 Sep 2020 17:49:14 +0800 From: Shawn Guo To: Meenakshi Aggarwal Cc: "robh+dt@kernel.org" , Varun Sethi , Leo Li , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ioana Ciornei , Kuldeep Singh Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds board Message-ID: <20200912094913.GB25109@dragon> References: <1599059610-7570-1-git-send-email-meenakshi.aggarwal@nxp.com> <1599059610-7570-2-git-send-email-meenakshi.aggarwal@nxp.com> <20200905075419.GN9261@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Sep 09, 2020 at 07:10:12AM +0000, Meenakshi Aggarwal wrote: > > > + sb_3v3: regulator-sb3v3 { > > > + compatible = "regulator-fixed"; > > > + regulator-name = "MC34717-3.3VSB"; > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <3300000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > > I do not see any point to have regulator-boot-on or regulator-always-on for a > > regulator that doesn't have on/off control. > [Meenakshi Aggarwal] Properties are added to specify that platform firmware's out of reset configuration enabled the regulator and > regulator should never be disabled or change its operative status. What I was wondering if how this regulator is enabled by firmware, by some GPIO control? In that case, 'gpio' property should be there to describe the GPIO control. > > Can you help in understanding why these optional properties cannot be used together It's totally fine to use these properties together. But if the regulator doesn't have on/off control, neither of them makes sense. Shawn