From: Rob Herring <robh@kernel.org>
To: "Bao D. Nguyen" <nguyenb@codeaurora.org>
Cc: cang@codeaurora.org, asutoshd@codeaurora.org,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Avri Altman <Avri.Altman@wdc.com>, Vinod Koul <vkoul@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS
Date: Mon, 14 Sep 2020 12:35:05 -0600 [thread overview]
Message-ID: <20200914183505.GA357@bogus> (raw)
In-Reply-To: <0a9d395dc38433501f9652a9236856d0ac840b77.1598939393.git.nguyenb@codeaurora.org>
On Mon, Aug 31, 2020 at 11:00:47PM -0700, Bao D. Nguyen wrote:
> UFS's specifications supports a range of Vcc operating
> voltage levels. Add documentation for the UFS's Vcc voltage
> levels setting.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
> ---
> Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> index 415ccdd..7257b32 100644
> --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> @@ -23,6 +23,8 @@ Optional properties:
> with "phys" attribute, provides phandle to UFS PHY node
> - vdd-hba-supply : phandle to UFS host controller supply regulator node
> - vcc-supply : phandle to VCC supply regulator node
> +- vcc-voltage-level : specifies voltage levels for VCC supply.
> + Should be specified in pairs (min, max), units uV.
The expectation is the regulator pointed to by 'vcc-supply' has the
voltage constraints. Those constraints are supposed to be the board
constraints, not the regulator operating design constraints. If that
doesn't work for your case, then it should be addressed in a common way
for the regulator binding.
Also, properties with units must have a unit suffix.
Rob
next prev parent reply other threads:[~2020-09-14 18:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1598939393.git.nguyenb@codeaurora.org>
2020-09-01 6:00 ` [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS Bao D. Nguyen
2020-09-13 9:35 ` Avri Altman
2020-09-14 16:19 ` nguyenb
2020-09-14 18:35 ` Rob Herring [this message]
2020-09-15 8:10 ` nguyenb
2020-09-18 19:01 ` Rob Herring
2020-09-22 0:22 ` nguyenb
2020-09-22 0:36 ` Bjorn Andersson
2020-09-23 17:32 ` nguyenb
2020-09-15 4:41 ` Bjorn Andersson
2020-09-15 8:14 ` nguyenb
2020-09-15 13:43 ` Bjorn Andersson
2020-09-15 16:47 ` nguyenb
2020-09-15 18:36 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914183505.GA357@bogus \
--to=robh@kernel.org \
--cc=Avri.Altman@wdc.com \
--cc=asutoshd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).