From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F8DCC433E2 for ; Tue, 15 Sep 2020 05:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2408920897 for ; Tue, 15 Sep 2020 05:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726131AbgIOFla (ORCPT ); Tue, 15 Sep 2020 01:41:30 -0400 Received: from verein.lst.de ([213.95.11.211]:46357 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbgIOFl2 (ORCPT ); Tue, 15 Sep 2020 01:41:28 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id BC6A26736F; Tue, 15 Sep 2020 07:41:22 +0200 (CEST) Date: Tue, 15 Sep 2020 07:41:22 +0200 From: Christoph Hellwig To: Mathieu Poirier Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, Russell King , Santosh Shilimkar , Greg Kroah-Hartman , Jim Quinlan , Nathan Chancellor , Florian Fainelli , Robin Murphy , Rob Herring , Frank Rowand , Ohad Ben-Cohen , Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, arnaud.pouliquen@st.com, loic.pallardy.st.com@lst.de Subject: Re: [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Message-ID: <20200915054122.GA18079@lst.de> References: <20200914073343.1579578-1-hch@lst.de> <20200914073343.1579578-7-hch@lst.de> <20200914230147.GA3251212@xps15> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200914230147.GA3251212@xps15> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Sep 14, 2020 at 05:01:47PM -0600, Mathieu Poirier wrote: [700 lines of the fullquote deleted..] > > + for (r = map; r->size; r++) > > + num_ranges++; > > + > > + new_map = kmemdup(map, array_size(num_ranges + 1, sizeof(*map)), > > + GFP_KERNEL); > > + if (!new_map) > > + return -ENOMEM; > > + to->dma_range_map = new_map; > > + return 0; > > +} > > + > > This patch seemed Ok to me but it broke the stm32 remoteproc implementation. When > I tested things out function dma_coerce_mask_and_cohenrent() returns -5 and the > rest of the initialisation fails. I isolated things to function dma_to_pfn() > [2]. In the original implementation __bus_to_pfn() returns 0xfffff and > dev->dma_pfn_offset is equal to 0x38000. As such the function returns 0x137fff > and dma_supported() a non-zero value[3]. > > With this set function dma_to_pfn() received a face lift. Function > __bus_to_pfn() still returns 0xfffff but translate_dma_to_phys() returns 0, > which forces dma_supported() to also return 0 and that is where the -5 (-EIO) > comes from. > > Taking a futher look at translate_dma_to_phy(), @dma_addr never falls within the > bus_dma_region ranges and returns 0. > > I'm suspecting an initialisation problem and if it occurred here, it will > likely show up elsewhere. Can you try this incremental patch? diff --git a/include/linux/dma-direct.h b/include/linux/dma-direct.h index 088c97181ab146..c6b21acba7a459 100644 --- a/include/linux/dma-direct.h +++ b/include/linux/dma-direct.h @@ -46,7 +46,7 @@ static inline phys_addr_t translate_dma_to_phys(struct device *dev, if (dma_addr >= m->dma_start && dma_addr - m->dma_start < m->size) return (phys_addr_t)dma_addr + m->offset; - return 0; + return (phys_addr_t)-1; } #ifdef CONFIG_ARCH_HAS_PHYS_TO_DMA