From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12597C43461 for ; Tue, 15 Sep 2020 12:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3988206DB for ; Tue, 15 Sep 2020 12:21:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zpeXFfeQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbgIOMV1 (ORCPT ); Tue, 15 Sep 2020 08:21:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbgIOMST (ORCPT ); Tue, 15 Sep 2020 08:18:19 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10479C061788 for ; Tue, 15 Sep 2020 05:18:18 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id s14so2648245pju.1 for ; Tue, 15 Sep 2020 05:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nbCCWekL43KfUuOb/G6hgfPLbnYNED78GQ0qDdOnzpg=; b=zpeXFfeQ9pIHDDg61cyiROUOxLNB7NyDkxTbOkZVxp2ACA67PZVOD3REwq4HuG1mQG 3Rm9sM96iDnDIcHGw1j8eVHj9GBZfTwpkUD+ICbN7JOb8/23UT60oS1RisQOli+OOJPl 1wMhpQP3iY1aqmz8HVy+MDe33RLTOHK9CsX9YTX49Kf4jvDGujXqrCJYUtreN53bHVwo rVSv5MpF3q98cnufM8i+Jsju65X6gB+tj5ldkhmC/dhW+/1GDlfMoLOh3Rmf+9QO5XQJ QTDSjX/mraSMxWn0wxcuZVTVc6eu6yi4HQTJE/nQ62w7z/0qHmzwvvlvQ6yZyipCkysq Elgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nbCCWekL43KfUuOb/G6hgfPLbnYNED78GQ0qDdOnzpg=; b=dKelDW/GmuwiafVzAXpz38NzB2H5ia0zMoYVhILw9S2j2+Ry6hO50XZ9P8QJQAZG9L VX1WgnMrfo7h3DVxMQV1RAqCe5NyXyKtNzAl8+umqQrvutb/TdajWbQLo4/jaWKpEG/k Zkh4T3M08SQwTL5I5IEnc0ywAuTobICqsryqcB+NvLnbN+Lgag0tKlA0FP112/kRC7+P GguZZkTNDfwIWcZK0tU4P44BECz/YJbj4bmhpTS/5I4SBr2s+6SF0hi4WkrrLvVPvIwo 7nkN/37vgcEwlNIEI5vbVuIYaWh+lVX12TmsV2pEqU4Pugyx8jUCo72s9U0wghy860Km oZ/w== X-Gm-Message-State: AOAM533eRVcIZh9/skbTh0P0x8LLT6kw93nw4t97e++d0xhrQrs53fDY 1XO2EhsffMh2m9WFwioe19DRjHhOmjrMciI= X-Google-Smtp-Source: ABdhPJxoyrUz1MFiKZV+Agmkv57dnRtAjxRDCDmoksm3+ufqY0huq6t19voTIT9znT43ltPOYeT5mw== X-Received: by 2002:a17:902:bb84:b029:d1:e5e7:bdd4 with SMTP id m4-20020a170902bb84b02900d1e5e7bdd4mr1492343pls.52.1600172297761; Tue, 15 Sep 2020 05:18:17 -0700 (PDT) Received: from mani ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id u4sm13881233pfk.166.2020.09.15.05.18.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Sep 2020 05:18:17 -0700 (PDT) Date: Tue, 15 Sep 2020 17:48:11 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] arm64: dts: sm8250: Add OPP table for all qup devices Message-ID: <20200915121811.GE12395@mani> References: <20200915120203.290295-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915120203.290295-1-dmitry.baryshkov@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Sep 15, 2020 at 03:02:03PM +0300, Dmitry Baryshkov wrote: > qup has a requirement to vote on the performance state of the CX domain > in sm8250 devices. Add OPP tables for these and also add power-domains > property for all qup instances for uart and spi. > i2c does not support scaling and uses a fixed clock. > > Signed-off-by: Dmitry Baryshkov Acked-by: Manivannan Sadhasivam Thanks, Mani > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 69 ++++++++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index c989bc1370ab..6cd45a667ba9 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -411,6 +411,25 @@ ipcc: mailbox@408000 { > #mbox-cells = <2>; > }; > > + qup_opp_table: qup-opp-table { > + compatible = "operating-points-v2"; > + > + opp-50000000 { > + opp-hz = /bits/ 64 <50000000>; > + required-opps = <&rpmhpd_opp_min_svs>; > + }; > + > + opp-75000000 { > + opp-hz = /bits/ 64 <75000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + > + opp-120000000 { > + opp-hz = /bits/ 64 <120000000>; > + required-opps = <&rpmhpd_opp_svs>; > + }; > + }; > + > qupv3_id_2: geniqup@8c0000 { > compatible = "qcom,geni-se-qup"; > reg = <0x0 0x008c0000 0x0 0x6000>; > @@ -445,6 +464,8 @@ spi14: spi@880000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -471,6 +492,8 @@ spi15: spi@884000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -497,6 +520,8 @@ spi16: spi@888000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -523,6 +548,8 @@ spi17: spi@88c000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -534,6 +561,8 @@ uart17: serial@88c000 { > pinctrl-names = "default"; > pinctrl-0 = <&qup_uart17_default>; > interrupts = ; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -560,6 +589,8 @@ spi18: spi@890000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -571,6 +602,8 @@ uart18: serial@890000 { > pinctrl-names = "default"; > pinctrl-0 = <&qup_uart18_default>; > interrupts = ; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -597,6 +630,8 @@ spi19: spi@894000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > }; > @@ -635,6 +670,8 @@ spi0: spi@980000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -661,6 +698,8 @@ spi1: spi@984000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -687,6 +726,8 @@ spi2: spi@988000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -698,6 +739,8 @@ uart2: serial@988000 { > pinctrl-names = "default"; > pinctrl-0 = <&qup_uart2_default>; > interrupts = ; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -724,6 +767,8 @@ spi3: spi@98c000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -750,6 +795,8 @@ spi4: spi@990000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -776,6 +823,8 @@ spi5: spi@994000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -802,6 +851,8 @@ spi6: spi@998000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -813,6 +864,8 @@ uart6: serial@998000 { > pinctrl-names = "default"; > pinctrl-0 = <&qup_uart6_default>; > interrupts = ; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -839,6 +892,8 @@ spi7: spi@99c000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > }; > @@ -877,6 +932,8 @@ spi8: spi@a80000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -903,6 +960,8 @@ spi9: spi@a84000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -929,6 +988,8 @@ spi10: spi@a88000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -955,6 +1016,8 @@ spi11: spi@a8c000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -981,6 +1044,8 @@ spi12: spi@a90000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -992,6 +1057,8 @@ uart12: serial@a90000 { > pinctrl-names = "default"; > pinctrl-0 = <&qup_uart12_default>; > interrupts = ; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > > @@ -1018,6 +1085,8 @@ spi13: spi@a94000 { > interrupts = ; > #address-cells = <1>; > #size-cells = <0>; > + power-domains = <&rpmhpd SM8250_CX>; > + operating-points-v2 = <&qup_opp_table>; > status = "disabled"; > }; > }; > -- > 2.28.0 >