From: Rob Herring <robh@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Frank Rowand <frowand.list@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bastien Nocera <hadess@hadess.net>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
linux-usb@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Peter Chen <peter.chen@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add binding for onboard USB hubs
Date: Tue, 15 Sep 2020 08:21:45 -0600 [thread overview]
Message-ID: <20200915142145.GA1861636@bogus> (raw)
In-Reply-To: <20200914112716.1.I248292623d3d0f6a4f0c5bc58478ca3c0062b49a@changeid>
On Mon, Sep 14, 2020 at 11:27:48AM -0700, Matthias Kaehlcke wrote:
> Onboard USB hubs need to be powered and may require initiaization of
> other resources (like GPIOs or clocks) to work properly. This adds
> a device tree binding for these hubs.
We already have bindings for these. 2 in fact as I2C controlled hubs are
often described under the I2C bus.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
> .../bindings/usb/onboard_usb_hub.yaml | 70 +++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml b/Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml
> new file mode 100644
> index 000000000000..f82d8f459eed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/onboard_usb_hub.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Binding for onboard USB hubs
> +
> +maintainers:
> + - Matthias Kaehlcke <mka@chromium.org>
> +
> +allOf:
> + - $ref: /schemas/usb/onboard_usb_hub.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - onboard-usb-hub
> + - realtek,rts5411
> +
> + power-off-in-suspend:
> + description:
> + The hub should be powered off during system suspend. When the
> + "wakeup-source" property is also provided the hub is only powered
> + off during suspend when no wakeup capable descendants are connected.
> + type: boolean
> +
> + vdd-supply:
> + description:
> + phandle to the regulator that provides power to the hub.
> +
> + wakeup-source:
> + description:
> + Wakeup capable USB devices connected to this hub can be used as
> + wakeup source.
> + type: boolean
> +
> +required:
> + - compatible
> + - vdd-supply
> +
> +examples:
> + - |
> + usb_hub: usb-hub {
> + compatible = "realtek,rts5411", "onboard-usb-hub";
> + vdd-supply = <&pp3300_hub>;
> + power-off-in-suspend;
> + wakeup-source;
This is the hub device?
> + };
> +
> + &usb_1_dwc3 {
> + dr_mode = "host";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* 2.0 hub on port 1 */
> + hub@1 {
> + compatible = "usbbda,5411";
> + reg = <1>;
> + hub = <&usb_hub>;
Or this node is?
> + };
> +
> + /* 3.0 hub on port 2 */
> + hub@2 {
> + compatible = "usbbda,411";
> + reg = <2>;
> + hub = <&usb_hub>;
Or this node is?
The hub node belongs here.
If you really have it connected to 2 upstream ports, then just do
one node with 'reg = <1 2>;'.
Rob
> + };
> +
> +...
> --
> 2.28.0.618.gf4bc123cb7-goog
>
next prev parent reply other threads:[~2020-09-16 0:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 18:27 [PATCH 1/2] dt-bindings: usb: Add binding for onboard USB hubs Matthias Kaehlcke
2020-09-14 18:27 ` [PATCH 2/2] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2020-09-14 19:52 ` Matthias Kaehlcke
2020-09-14 20:14 ` Alan Stern
2020-09-14 21:14 ` Matthias Kaehlcke
2020-09-15 2:55 ` Peter Chen
2020-09-15 5:02 ` Matthias Kaehlcke
2020-09-15 7:05 ` Peter Chen
2020-09-15 23:03 ` Matthias Kaehlcke
2020-09-16 2:14 ` Alan Stern
2020-09-16 19:27 ` Matthias Kaehlcke
2020-09-16 8:19 ` Peter Chen
2020-09-16 19:16 ` Matthias Kaehlcke
2020-09-17 0:27 ` Peter Chen
2020-09-17 0:47 ` Matthias Kaehlcke
2020-09-17 1:24 ` Peter Chen
2020-09-17 15:54 ` Matthias Kaehlcke
2020-09-15 14:21 ` Rob Herring [this message]
2020-09-16 0:00 ` [PATCH 1/2] dt-bindings: usb: Add binding for onboard USB hubs Matthias Kaehlcke
2020-09-18 16:05 ` Rob Herring
2020-09-22 23:39 ` Matthias Kaehlcke
2020-09-15 14:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915142145.GA1861636@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=peter.chen@nxp.com \
--cc=ravisadineni@chromium.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).