From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60262C43461 for ; Wed, 16 Sep 2020 00:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FB8220739 for ; Wed, 16 Sep 2020 00:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600215394; bh=npnO+iegIXZPSDBKqy7AopryQmSfMlDeEx5QRhUBtsI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CzDUbbUBnihnpip9gD/FGvpQO1qL9xjALRPkaqmFbi9f5qzP7wKaV78qfxLCyuY8O o+bJzv1Hias/HiNa+JEC3B2Mjt0RKRhJr/egm6UzGQLRjuAEUGQx9vHXPKYxTz178j SYCXrpT7rZngf4MDN72pnYeenTcrb5pNiKXuldBc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727095AbgIPAQc (ORCPT ); Tue, 15 Sep 2020 20:16:32 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:38413 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726703AbgIOOXr (ORCPT ); Tue, 15 Sep 2020 10:23:47 -0400 Received: by mail-il1-f195.google.com with SMTP id t18so3165012ilp.5; Tue, 15 Sep 2020 07:21:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mv7dyR4sjl+BVQ9RdeFPf0paoZFTYPDkq70MlZEfWDQ=; b=iDfEoSWo32MjSNwMX7a2+EMX832f+0ombq9JJntlHfF3jFhT6SZc00MwPf8QxqlrgT /60zssamyvjLg+WQo+kN0BGlPr2FZ5dYo95JJ+QRxxHjk+anDFIfaqAaLjR85PK3eLuH VzWntuzxeUziwvxLQLYI36lC4Sf7o+PKZMty8aDMSsaP4Ln6OtilrkvKtyQ+32OtjvrM p8ErnfKn5u1wVgHGCOj1n3xnPySma34Tu/t90MUxwiVq0GL5ItcOOsQLF/WA5aHBZBB+ 040k6+7o6/wiIG4Spph/QxrpI7vRAbqKdZjBONNApWX2V1odvSkr3M364gDULnPwGSdL ynVQ== X-Gm-Message-State: AOAM531wwtWq3xCIl7VnJJEn27/s4YIHMBfTIvC94zDKgm43zbkhssCa wZurp6+phVNITlnxTmrkjA== X-Google-Smtp-Source: ABdhPJyyM19BYSpWbpH3kwRqswRw9fK5YfGImOr7xdoFoH6gheQZQGCGUsYKmRyVAw4pJCa4LotBRQ== X-Received: by 2002:a92:4f:: with SMTP id 76mr15938072ila.11.1600179715629; Tue, 15 Sep 2020 07:21:55 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id m19sm9007665ila.40.2020.09.15.07.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 07:21:54 -0700 (PDT) Received: (nullmailer pid 1873453 invoked by uid 1000); Tue, 15 Sep 2020 14:21:53 -0000 Date: Tue, 15 Sep 2020 08:21:53 -0600 From: Rob Herring To: Matthias Kaehlcke Cc: Frank Rowand , Bastien Nocera , Peter Chen , Douglas Anderson , Alan Stern , Stephen Boyd , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Greg Kroah-Hartman Subject: Re: [PATCH 1/2] dt-bindings: usb: Add binding for onboard USB hubs Message-ID: <20200915142153.GB1861636@bogus> References: <20200914112716.1.I248292623d3d0f6a4f0c5bc58478ca3c0062b49a@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200914112716.1.I248292623d3d0f6a4f0c5bc58478ca3c0062b49a@changeid> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 14 Sep 2020 11:27:48 -0700, Matthias Kaehlcke wrote: > Onboard USB hubs need to be powered and may require initiaization of > other resources (like GPIOs or clocks) to work properly. This adds > a device tree binding for these hubs. > > Signed-off-by: Matthias Kaehlcke > --- > > .../bindings/usb/onboard_usb_hub.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml > My bot found errors running 'make dt_binding_check' on your patch: Traceback (most recent call last): File "/usr/local/bin/dt-extract-example", line 45, in binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load return constructor.get_single_data() File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data node = self.composer.get_single_node() File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node File "_ruamel_yaml.pyx", line 848, in _ruamel_yaml.CParser._compose_sequence_node File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event ruamel.yaml.scanner.ScannerError: while scanning a block scalar in "", line 43, column 5 found a tab character where an indentation space is expected in "", line 52, column 1 make[1]: *** [Documentation/devicetree/bindings/Makefile:18: Documentation/devicetree/bindings/usb/onboard_usb_hub.example.dts] Error 1 make[1]: *** Deleting file 'Documentation/devicetree/bindings/usb/onboard_usb_hub.example.dts' make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml: while scanning a block scalar in "", line 43, column 5 found a tab character where an indentation space is expected in "", line 52, column 1 /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml: ignoring, error parsing file warning: no schema found in file: ./Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml make: *** [Makefile:1366: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1363875 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.