From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07133C433E2 for ; Tue, 15 Sep 2020 22:53:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDF0320770 for ; Tue, 15 Sep 2020 22:53:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kS8R9V2m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727388AbgIOWxe (ORCPT ); Tue, 15 Sep 2020 18:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbgIOPjo (ORCPT ); Tue, 15 Sep 2020 11:39:44 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73C23C061220 for ; Tue, 15 Sep 2020 08:38:59 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id t20so3483111qtr.8 for ; Tue, 15 Sep 2020 08:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HC238Ige8DRb8ygAtnYFCL6nACxI3bOXmHHkEflAUkI=; b=kS8R9V2mdJvLcV9YbZYn94h6pcHob1/i65DmFV0rTmUFeBnMVwH1UwQ1e3RfuTRBr7 Zh3eemuHz1S8S9a6kky4amFbSTof972VgE3Gn2JEzDPVwBbxIWmt/Jcscdu55bCn3eHl qB5AickfsqTZpO14l85evEOWKtuUu4m38QzYDlSyu9AHe3aXbqPX8ZBPj5jDI9tU0pST VVkGollQ97Hw6Gzi9acjW4ndP/vySxGJ7Es5F2Zg5H0RroFO5sSJw/XlyBoTgE3FF2DR 6oGLMyC5uMT2xn5pi6UtTFLstk+Mh/pxrhdRuRdDG5iVV7YAtAVMsNG/xTsSdk4T/1Rt ewCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HC238Ige8DRb8ygAtnYFCL6nACxI3bOXmHHkEflAUkI=; b=pHizHOO6YW3ZQtCDWseG1ckj8bqQXhMzyWebdF9XTWfE9xqlCtkXV03r2DZuR6LlOQ GHlventznHd1JEutpAs23GF8zvKfncdY/Qd9/T27/qBuhDKj9IKJOlGMNqg/oqdzkwz8 syP6a+F/6G+11F4k5jvXry6O5NJgtHRMx8tscfkcFCld1Eq0P7/sATPqY2C9d2jXIqzB NcBae7fVC6F4sMNYGLctQ9yD3hunOhbmSmMZ0A3ZBBCQBOcitzuVzNqIWkxGS1QHcII0 5sYNyf/7E0s3WvxJlj0yEhFmRKHI4Pnpm9Q2BbliW4WkRyeDkYYoLTmQr0rktqSPWsOJ 1X+w== X-Gm-Message-State: AOAM532TvrcQ9Hu8s0Byn5Cx6rhK5BU+7+x5LOh/j/58xN9gxaaRg69D M9v3mz40nqp+ER5gTbNfo6zY/w== X-Google-Smtp-Source: ABdhPJzNq44unJ9cfA4NcVtVXuI98pXkT64mh9kNx76o1npSpbPUKHJCbfUfbVHS1n5Z6ufNIW+rZA== X-Received: by 2002:ac8:76cb:: with SMTP id q11mr6175301qtr.63.1600184336642; Tue, 15 Sep 2020 08:38:56 -0700 (PDT) Received: from uller (ec2-34-197-84-77.compute-1.amazonaws.com. [34.197.84.77]) by smtp.gmail.com with ESMTPSA id x126sm18337154qka.91.2020.09.15.08.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 08:38:56 -0700 (PDT) Date: Tue, 15 Sep 2020 15:38:54 +0000 From: Bjorn Andersson To: Stephan Gerhold Cc: Andy Gross , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Amit Kucheria , ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH 06/14] arm64: dts: qcom: msm8916: Drop qcom,tcsr-mutex syscon Message-ID: <20200915153854.GE478@uller> References: <20200915071221.72895-1-stephan@gerhold.net> <20200915071221.72895-7-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915071221.72895-7-stephan@gerhold.net> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 15 Sep 07:12 UTC 2020, Stephan Gerhold wrote: > The hwlock device node does not (directly) use memory resources > of the SoC, so we should move it outside the "soc" node. > > However, as of commit 7a1e6fb1c606 ("hwspinlock: qcom: Allow mmio usage > in addition to syscon") we can now assign the memory region directly > to the hwlock device node. This works because the register space > used by it is actually separate and not used by any other components. > A side-note on that... In addition to the listed commit, it was also determined that the old two-node split is prohibited and the DT binding was updated to deprecate it. So in the event of us having to also access registers from e.g. the remoteproc driver (which 8916 doesn't doesn't do), we would have to use: compatible = "qcom,tcsr-mutex", "syscon"; Regards, Bjorn > Signed-off-by: Stephan Gerhold > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 003451ccf3ee..10e177988555 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -458,9 +458,10 @@ gcc: clock-controller@1800000 { > reg = <0x1800000 0x80000>; > }; > > - tcsr_mutex_regs: syscon@1905000 { > - compatible = "syscon"; > + tcsr_mutex: hwlock@1905000 { > + compatible = "qcom,tcsr-mutex"; > reg = <0x1905000 0x20000>; > + #hwlock-cells = <1>; > }; > > tcsr: syscon@1937000 { > @@ -468,12 +469,6 @@ tcsr: syscon@1937000 { > reg = <0x1937000 0x30000>; > }; > > - tcsr_mutex: hwlock { > - compatible = "qcom,tcsr-mutex"; > - syscon = <&tcsr_mutex_regs 0 0x1000>; > - #hwlock-cells = <1>; > - }; > - > rpm_msg_ram: memory@60000 { > compatible = "qcom,rpm-msg-ram"; > reg = <0x60000 0x8000>; > -- > 2.28.0 >